Update guide: "Easy profiling for Node.js" #449
Conversation
Instructions on using the tick processor now use the flag on the Node.js binary --prof-process which was introduced in v5.2.0. Fixes #447
|
cc @Trott |
|
LGTM |
|
|
||
| ``` | ||
| node <path_to_nodejs_src>/tools/v8-prof/tick-processor.js isolate-0x101804c00-v8.log >processed.txt | ||
| node --prof-process isolate-0x101804c00-v8.log >processed.txt |
There was a problem hiding this comment.
Nit: We probably want to find some way to generalize the file name. I wouldn't hold this up for that, though, if that is likely to be the source of much bike-shedding.
There was a problem hiding this comment.
Can we please keep the old command as well for users of 4.2 (LTS)?
There was a problem hiding this comment.
Based on the discussion here, it seems likely that this change will land in LTS. My hope is to update the guide at that time to move the required version back from 5.2.0 to 4.2.x.
There was a problem hiding this comment.
If someone wants to merge #446, great! If you'd rather just add that change into here yourself, that's great too!
|
Closing this in favor of #449. Guessing it could be re-opened if |
Instructions on using the tick processor now use the flag on the Node.js
binary --prof-process which was introduced in v5.2.0.
Fixes #447