Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profiling Guide Requires Updates #447

Closed
Trott opened this issue Jan 5, 2016 · 3 comments
Closed

Profiling Guide Requires Updates #447

Trott opened this issue Jan 5, 2016 · 3 comments

Comments

@Trott
Copy link
Member

Trott commented Jan 5, 2016

In light of nodejs/node#3032, there is some stuff in the simple profiling guide that can be simplified. Maybe @matthewloring can indicate what needs to change? It might just be the part about making sure to use the same version of tick-processor as came with the source and how to fire up the tick processor? Not sure anything else...
@matthewloring
Copy link
Contributor

@Trott Thank you for noticing this. I'll submit a PR with updates now that the tick processor is bundled with the node binary.

@matthewloring matthewloring mentioned this issue Jan 6, 2016
Closed
@srlowe
Copy link

srlowe commented Mar 13, 2016

The page is still referring to the v8 profiling tools in the source code (which I believe are no longer included).

@matthewloring
Copy link
Contributor

Good catch. Actually, the integration of the --prof-process flag into the LTS branch means we should remove all mention of scripts from the guide.

matthewloring added a commit that referenced this issue Mar 14, 2016
@matthewloring
Update guide: "Easy profiling for Node.js"
1e1aa2d 
Instructions on using the tick processor now use the flag on the Node.js
binary --prof-process for all versions and remove mention of processing
scripts (which are now removed).

Fixes #447
@matthewloring matthewloring mentioned this issue Mar 14, 2016
Merged
@ghost ghost closed this as completed in #575 Mar 14, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Trott @matthewloring @srlowe