docs: add note about default padding for publicDecrypt/privateEncrypt #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Edit: oop, looks like the first line of your commit is longer than 50 characters. Could you fix that? @calvinmetcalf |
Adds a note that the default padding for publicDecrypt/privateEncrypt is RSA_PKCS1_PADDING instead of RSA_PKCS1_OAEP_PADDING as it is for privateDecrypt/publicEncrypt.
calvinmetcalf
force-pushed
the
publicDecryptPadding
branch
from
0d411e7
to
b1b447a
Compare
|
oops fixed |
brendanashworth
pushed a commit
that referenced
this pull request
Jan 30, 2015
Adds a note that the default padding for publicDecrypt/privateEncrypt is RSA_PKCS1_PADDING instead of RSA_PKCS1_OAEP_PADDING as it is for privateDecrypt/publicEncrypt. PR-URL: #659 Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
|
Landed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a note that the default padding for publicDecrypt/privateEncrypt
is RSA_PKCS1_PADDING instead of RSA_PKCS1_OAEP_PADDING as it is for
privateDecrypt/publicEncrypt.