Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix vm bug for configurable globalThis #51602

Merged
merged 1 commit into from
Feb 1, 2024
Merged

src: fix vm bug for configurable globalThis #51602

merged 1 commit into from
Feb 1, 2024

Commits on Jan 31, 2024

  1. src: fix vm bug for configurable globalThis 

    Object.defineProperty allows to change the value for
non-writable properties if they are configurable. We
missed that case when checking if a
property is read-only.

Fixes: nodejs#47799
    @fhinkel
    fhinkel committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    d69a04d View commit details
    Browse the repository at this point in the history