src: fix vm bug for configurable globalThis #51602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
fhinkel
force-pushed
the
vm-configurable-not-writable
branch
from
a876259
to
bf79653
Compare
github-actions
bot
removed
the
request-ci
targos
approved these changes
Jan 30, 2024
aduh95
added
the
author ready
lpinca
approved these changes
Jan 30, 2024
Object.defineProperty allows to change the value for non-writable properties if they are configurable. We missed that case when checking if a property is read-only. Fixes: nodejs#47799
fhinkel
force-pushed
the
vm-configurable-not-writable
branch
from
2510adc
to
d69a04d
Compare
github-actions
bot
removed
the
request-ci
fhinkel
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/51602 ✔ Done loading data for nodejs/node/pull/51602 ----------------------------------- PR info ------------------------------------ Title src: fix vm bug for configurable globalThis (#51602) Author F. Hinkelmann (@fhinkel) Branch fhinkel:vm-configurable-not-writable -> nodejs:main Labels c++, vm, author ready, needs-ci Commits 1 - src: fix vm bug for configurable globalThis Committers 1 - Franziska Hinkelmann PR-URL: https://github.com/nodejs/node/pull/51602 Fixes: https://github.com/nodejs/node/issues/47799 Reviewed-By: Matteo Collina Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51602 Fixes: https://github.com/nodejs/node/issues/47799 Reviewed-By: Matteo Collina Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - src: fix vm bug for configurable globalThis ℹ This PR was created on Tue, 30 Jan 2024 00:34:38 GMT ✔ Approvals: 3 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/51602#pullrequestreview-1850401295 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/51602#pullrequestreview-1850404038 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/51602#pullrequestreview-1852297658 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-01-31T20:17:51Z: https://ci.nodejs.org/job/node-test-pull-request/56994/ - Querying data for job/node-test-pull-request/56994/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/7734474109 |
mcollina
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 1cd9a95 |
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Feb 9, 2024
Object.defineProperty allows to change the value for non-writable properties if they are configurable. We missed that case when checking if a property is read-only. Fixes: nodejs#47799 PR-URL: nodejs#51602 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Feb 15, 2024
Object.defineProperty allows to change the value for non-writable properties if they are configurable. We missed that case when checking if a property is read-only. Fixes: #47799 PR-URL: #51602 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito
pushed a commit
to marco-ippolito/node
that referenced
this pull request
Feb 19, 2024
Object.defineProperty allows to change the value for non-writable properties if they are configurable. We missed that case when checking if a property is read-only. Fixes: nodejs#47799 PR-URL: nodejs#51602 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
Object.defineProperty allows to change the value for non-writable properties if they are configurable. We missed that case when checking if a property is read-only. Fixes: #47799 PR-URL: #51602 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
Object.defineProperty allows to change the value for non-writable properties if they are configurable. We missed that case when checking if a property is read-only. Fixes: #47799 PR-URL: #51602 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Object.defineProperty allows to change the value for non-writable properties if they are configurable. We missed that case in the vm module when checking if a property is read-only.
Fixes: #47799
cc @domenic