Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: deprecate thenable support #40860

Merged
merged 6 commits into from
Nov 26, 2021
Merged

stream: deprecate thenable support #40860

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a055bcf
stream: deprecate thenable support
ronag Nov 10, 2021
7422c7a
squash! downgrade to doc-only deprecation
aduh95 Nov 18, 2021
8750b92
Update doc/api/deprecations.md
ronag Nov 22, 2021
e847e1b
squash! Update doc/api/deprecations.md
aduh95 Nov 22, 2021
002896a
squash! Update doc/api/deprecations.md
aduh95 Nov 22, 2021
fa5281d
fix linter and improve wording
aduh95 Nov 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions doc/api/deprecations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3019,6 +3019,22 @@ should have the same effect. The receiving end should also check the
[`readable.readableEnded`][] value on [`http.IncomingMessage`][] to get whether
it was an aborted or graceful destroy.

### DEP0157: Thenable support in streams

<!-- YAML
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/40860
description: Documentation-only deprecation.
-->

Type: Documentation-only

An undocumented feature of Node.js streams was to support thenables in
implementation methods. This feature was causing stream instability when using
async functions as stream methods. This is now deprecated, instead use
callbacks.

aduh95 marked this conversation as resolved.
Show resolved Hide resolved
[Legacy URL API]: url.md#legacy-url-api
[NIST SP 800-38D]: https://nvlpubs.nist.gov/nistpubs/Legacy/SP/nistspecialpublication800-38d.pdf
[RFC 6066]: https://tools.ietf.org/html/rfc6066#section-3
Expand Down