Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: deprecate thenable support #40860

Merged
merged 6 commits into from
Nov 26, 2021
Merged

stream: deprecate thenable support #40860

merged 6 commits into from
Nov 26, 2021

Commits on Nov 18, 2021

  1. stream: deprecate thenable support 

    Deprecate support for returning thenables in stream
implementation methods. This is causing more confusion
and issues than it's worth, and never was documented.

Refs: nodejs#39535

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @ronag @aduh95
    ronag and aduh95 committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    a055bcf View commit details
    Browse the repository at this point in the history

  2. squash! downgrade to doc-only deprecation

    @aduh95
    aduh95 committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    7422c7a View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2021

  1. Update doc/api/deprecations.md 

    Co-authored-by: Matteo Collina <matteo.collina@gmail.com>
    @ronag @mcollina
    ronag and mcollina committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    8750b92 View commit details
    Browse the repository at this point in the history

  2. squash! Update doc/api/deprecations.md 

    Co-authored-by: Robert Nagy <ronagy@icloud.com>
    @aduh95 @ronag
    aduh95 and ronag committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    e847e1b View commit details
    Browse the repository at this point in the history

  3. squash! Update doc/api/deprecations.md

    @aduh95
    aduh95 committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    002896a View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2021

  1. fix linter and improve wording

    @aduh95
    aduh95 committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    fa5281d View commit details
    Browse the repository at this point in the history