Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v14.8.0 proposal #34704

Merged
merged 79 commits into from
Aug 11, 2020
Merged

v14.8.0 proposal #34704

merged 79 commits into from
Aug 11, 2020

Commits on Aug 4, 2020

  1. util: print External address from inspect

    Fixes: #28250
    
    PR-URL: #34398
    Backport-PR-URL: #34583
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    rosaxxny authored and Danielle Adams committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    f46649b View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2020

  1. console: document the behavior of console.assert()

    Add a description and an example of console.assert() call with
    no arguments. If called like this, the method should output:
    "Assertion failed".
    
    Fixes: #34500
    Refs: https://nodejs.org/dist/latest-v14.x/docs/api/console.html#console_console_assert_value_message
    Refs: https://console.spec.whatwg.org/#assert
    
    PR-URL: #34501
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: Zeyu Yang <himself65@outlook.com>
    iandrc authored and codebytere committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    465968c View commit details
    Browse the repository at this point in the history
  2. doc: use sentence-case for headers in SECURITY.md

    Our doc style guide calls for sentence-case in headers.
    
    PR-URL: #34525
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Stewart X Addison <sxa@uk.ibm.com>
    Trott authored and codebytere committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    692a735 View commit details
    Browse the repository at this point in the history
  3. build: toolchain.gypi and node_gyp.py cleanup

    Removed `linux_use_gold_flag`, `linux_use_bundled_gold` and `linux_use_bundled_binutils` flags from
    `tools/v8_gypfiles/toolchain.gypi` and `/tools/gyp_node.py`.
    
    Fixes: #34256
    
    PR-URL: #34268
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    iandrc authored and codebytere committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    70e9ece View commit details
    Browse the repository at this point in the history
  4. async_hooks: don't reuse resource in HttpAgent when queued

    PR-URL: #34439
    Fixes: #34401
    Refs: #27581
    Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    puzpuzpuz authored and codebytere committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    14656e1 View commit details
    Browse the repository at this point in the history
  5. test: remove unneeded flag check in test-vm-memleak

    The `common` module checks that necessary flags are being used, so a
    check in the test itself is no longer necessary.
    
    PR-URL: #34528
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and codebytere committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    9c442f9 View commit details
    Browse the repository at this point in the history
  6. n-api: simplify bigint-from-word creation

    Macro `CHECK_MAYBE_EMPTY_WITH_PREAMBLE()` does the work of checking
    the `TryCatch` and returning `napi_pending_exception` so this change
    reuses it for `napi_create_bigint_words()`.
    
    Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
    PR-URL: #34554
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Gabriel Schulhof authored and codebytere committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    2703fe4 View commit details
    Browse the repository at this point in the history
  7. build: auto start Jenkins CI via PR labels

    Add an Action that will find every PR with the `request-ci` label and
    will start a Jenkins CI for each of these Pull Requests. The scheduler
    event is used to circumvent GitHub Actions limitations on Pull Requests
    from forks (where secrets are not accessible and the GITHUB_TOKEN is
    read-only).
    
    If the Action fails to start a CI, it will add a `request-ci-failed`
    label and will leave a comment with the error message from NCU.
    
    Fixes: nodejs/github-bot#234
    
    PR-URL: #34089
    Reviewed-By: Christian Clauss <cclauss@me.com>
    mmarchini authored and codebytere committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    70cf3cb View commit details
    Browse the repository at this point in the history
  8. doc: update .mailmap for mmarchini

    PR-URL: #34586
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    mmarchini authored and codebytere committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    c8104f3 View commit details
    Browse the repository at this point in the history
  9. doc: update mmarchini contact info

    PR-URL: #34586
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    mmarchini authored and codebytere committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    7a28c3d View commit details
    Browse the repository at this point in the history
  10. doc: add mmarchini pronouns

    PR-URL: #34586
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    mmarchini authored and codebytere committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    212d17f View commit details
    Browse the repository at this point in the history
  11. n-api: support type-tagging objects

    `napi_instanceof()` is insufficient for reliably establishing the data
    type to which a pointer stored with `napi_wrap()` or
    `napi_create_external()` inside a JavaScript object points. Thus, we
    need a way to "mark" an object with a value that, when later retrieved,
    can unambiguously tell us whether it is safe to cast the pointer stored
    inside it to a certain structure.
    
    Such a check must survive loading/unloading/multiple instances of an
    addon, so we use UUIDs chosen *a priori*.
    
    Fixes: #28164
    Co-authored-by: Anna Henningsen <github@addaleax.net>
    PR-URL: #28237
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
    2 people authored and codebytere committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    8cc9e5e View commit details
    Browse the repository at this point in the history
  12. doc: use consistent capitalization for addons

    Sometimes _addon_ is capitalized and sometimes not. Capitalizing it
    seems peculiar and hard to justify. Standardize on treating it like
    other common nouns.
    
    PR-URL: #34536
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    Trott authored and codebytere committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    b69ff2f View commit details
    Browse the repository at this point in the history
  13. doc: simplify and clarify console.assert() documentation

    PR-URL: #34544
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and codebytere committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    f393ae9 View commit details
    Browse the repository at this point in the history
  14. doc: use consistent spelling for "falsy"

    We use "falsy" in multiple places in our docs, but only use "false-y" in
    one place in url.md. Replace it with "falsy".
    
    PR-URL: #34545
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Pranshu Srivastava <rexagod@gmail.com>
    Reviewed-By: Ron Korving <ron@ronkorving.nl>
    Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Trott authored and codebytere committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    be23e23 View commit details
    Browse the repository at this point in the history
  15. build: fix auto-start-ci script path

    PR-URL: #34588
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    mmarchini authored and codebytere committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    4af5dbd View commit details
    Browse the repository at this point in the history
  16. build: don't run auto-start-ci on push

    PR-URL: #34588
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    mmarchini authored and codebytere committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    befbaf3 View commit details
    Browse the repository at this point in the history
  17. esm: fix hook mistypes and links to types

    Prior to this commit, the custom loader hooks were:
    * missing the Node.js API ref docs types
    * missing the function signature from their sections
    * linking directly to the specification (not customary)
    * had an inconsistent non-nullable JSDoc promise return
    * had JSDoc object properties that weren't alpha-sorted
    * designated set of non-nullable types when single was fine
    
    Notes:
        https://www.typescriptlang.org/play/index.html?strictNullChecks=true&useJavaScript=true#code/PQKhCgAIUgBAHAhgJ0QW0gbwM4BdkCWAdgOYC+k28ApgMYEBmB1yUMCK6WmbkftAeyIATArgJDsALkgBCAILJUATwA8eQqQB8AGl58kyakVwBVAEoAZGbIAUG4iUgAfSAFcR1JkWrCAlHrQkGQUgibUAB64vByoGJgAYh604kIUwl6IbgA2uObU2ALZAG7UMUa4bshE2FgACsgCaATY1KqY7sjZMg6kwVpkbMDgkfACyLiQiNjKRLSQDMmpRJBGhSXU9jT0TCw6kGG4kbj7GQxZufnrpX5YUAeSkx2GxmZWkAC8kEQ52cGfD3CUQA3PdGJBbABZRC4AAWADpUCImrZblpIAAGeEAVluHWAwEgAGUmtRAaJlvD7nwCZAEuNKKTIAzENk-lQ6IxmMhsKcBIy0GTaG48E1INkBCQCPMGAy1kVio4qXwaYT5NkAO6IZS1CpVFaIFYCABGACs6JMBAxIHCybLkPEqt1IOp8I4BsqVXrqncVSqnTIXiYLJZIAB+al+77UDWQENbTm7ZD7INvSx+eGwozWqSRv0+WPxjk7bkZrNeQIqsigviDPjgqEwhFI4Qo26qTE4vGQWnyIgCW3IcliCRET2qyAAdVhxgOrOyjkgAAMzhc8gUFdQl-tbVNkCQ3IKTLVaIbIMayWgBKJdsJ4ZAAJIrOEtSO00+tSBiADktUQwlEPpDQHGch2KVk3DtBk0BhWhYUXMIKVHVlIFGcZcGwcdVmoSofVXHJ12uTZiy5PZfSjeFKMOY5Kz9RCR0kGQAG1KPhaiojYoQkMkfZv2AwcAFp6OWb8AF1aOCPwa2Ce5aQAES8FgbX5AA5a9qHhU1antKY2WZQdKG2UieU9b0Vnwy4Nw2BMSzI9iTkgCzCM3KTwDIIA
        https://closure-compiler.appspot.com/home#code%3D%252F%252F%2520%253D%253DClosureCompiler%253D%253D%250A%252F%252F%2520%2540compilation_level%2520ADVANCED_OPTIMIZATIONS%250A%252F%252F%2520%2540warning_level%2520VERBOSE%250A%252F%252F%2520%2540jscomp_error%2520strictCheckTypes%250A%252F%252F%2520%2540language_out%2520ECMASCRIPT_NEXT%250A%252F%252F%2520%2540checks_only%250A%252F%252F%2520%253D%253D%252FClosureCompiler%253D%253D%250A%250A%252F**%250A%2520*%2520%2540param%2520%257Bstring%257D%2520specifier%250A%2520*%2520%2540param%2520%257B%257B%250A%2520*%2520%2520%2520conditions%253A%2520!Array%253Cstring%253E%252C%250A%2520*%2520%2520%2520parentURL%253A%2520!(string%2520%257C%2520undefined)%252C%250A%2520*%2520%257D%257D%2520context%250A%2520*%2520%2540param%2520%257BFunction%257D%2520defaultResolve%250A%2520*%2520%2540returns%2520%257BPromise%253C%257B%2520url%253A%2520string%2520%257D%253E%257D%250A%2520*%252F%250Aexport%2520async%2520function%2520resolve(specifier%252C%2520context%252C%2520defaultResolve)%2520%257B%250A%2520%2520const%2520%257B%2520parentURL%2520%253D%2520null%2520%257D%2520%253D%2520context%253B%250A%2520%2520if%2520(Math.random()%2520%253E%25200.5)%2520%257B%2520%252F%252F%2520Some%2520condition.%250A%2520%2520%2520%2520%252F%252F%2520For%2520some%2520or%2520all%2520specifiers%252C%2520do%2520some%2520custom%2520logic%2520for%2520resolving.%250A%2520%2520%2520%2520%252F%252F%2520Always%2520return%2520an%2520object%2520of%2520the%2520form%2520%257Burl%253A%2520%253Cstring%253E%257D.%250A%2520%2520%2520%2520return%2520%257B%250A%2520%2520%2520%2520%2520%2520url%253A%2520parentURL%2520%253F%250A%2520%2520%2520%2520%2520%2520%2520%2520new%2520URL(specifier%252C%2520parentURL).href%2520%253A%250A%2520%2520%2520%2520%2520%2520%2520%2520new%2520URL(specifier).href%252C%250A%2520%2520%2520%2520%257D%253B%250A%2520%2520%257D%250A%2520%2520if%2520(Math.random()%2520%253C%25200.5)%2520%257B%2520%252F%252F%2520Another%2520condition.%250A%2520%2520%2520%2520%252F%252F%2520When%2520calling%2520%2560defaultResolve%2560%252C%2520the%2520arguments%2520can%2520be%2520modified.%2520In%2520this%250A%2520%2520%2520%2520%252F%252F%2520case%2520it's%2520adding%2520another%2520value%2520for%2520matching%2520conditional%2520exports.%250A%2520%2520%2520%2520return%2520defaultResolve(specifier%252C%2520%257B%250A%2520%2520%2520%2520%2520%2520...context%252C%250A%2520%2520%2520%2520%2520%2520conditions%253A%2520%255B...context.conditions%252C%2520'another-condition'%255D%252C%250A%2520%2520%2520%2520%257D)%253B%250A%2520%2520%257D%250A%2520%2520%252F%252F%2520Defer%2520to%2520Node.js%2520for%2520all%2520other%2520specifiers.%250A%2520%2520return%2520defaultResolve(specifier%252C%2520context%252C%2520defaultResolve)%253B%250A%257D
    
    PR-URL: #34240
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Guy Bedford <guybedford@gmail.com>
    Derek Lewis authored and codebytere committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    44e6c01 View commit details
    Browse the repository at this point in the history
  18. benchmark: always throw the same Error instance

    Stack trace capturing currently accounts for 40 % of the benchmark
    running time. Always throwing the same exception object removes
    that overhead and lets the benchmark be more focused on what it is
    supposed to measure.
    
    Refs: #34512 (comment)
    
    PR-URL: #34523
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    addaleax authored and codebytere committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    c4457d8 View commit details
    Browse the repository at this point in the history
  19. lib: absorb path error cases

    Absorb low level libuv failure in
    the process initialization phase
    
    Fixes: #33759
    Refs: #33759 (comment)
    PR-URL: #34519
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Zeyu Yang <himself65@outlook.com>
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    gireeshpunathil authored and codebytere committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    335cb0d View commit details
    Browse the repository at this point in the history
  20. doc: clarify N-API version 1

    Refs: nodejs/node-addon-api#760
    
    Clarify which version of 8.x in which N-API version 1
    matches the shape in later versions like 10.x
    
    Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>
    
    PR-URL: #34344
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
    mhdawson authored and codebytere committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    e2bea73 View commit details
    Browse the repository at this point in the history
  21. src: fix unused namespace member in node_util

    PR-URL: #34565
    Reviewed-By: Zeyu Yang <himself65@outlook.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    puzpuzpuz authored and codebytere committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    c1abc8d View commit details
    Browse the repository at this point in the history
  22. http: provide keep-alive timeout response header

    In http 1.1 persistent connection protocol there is a
    timing race where the client sends the request and then
    the server kills the connection (due to inactivity)
    before receiving the client's request.
    
    By providing a keep-alive header it is possible to provide
    the client a hint of when idle timeout would occur and
    avoid the race.
    
    Fixes: #34560
    
    PR-URL: #34561
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Zeyu Yang <himself65@outlook.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Pranshu Srivastava <rexagod@gmail.com>
    ronag authored and codebytere committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    36fd3da View commit details
    Browse the repository at this point in the history
  23. doc: revise N-API versions matrix text

    Revise text for clarity, brevity, and conformance with our style guide.
    
    PR-URL: #34566
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and codebytere committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    d7eaf3a View commit details
    Browse the repository at this point in the history
  24. http: reset headers timeout on headers complete

    headers timeout should not occur *after* headers have been
    received.
    
    Fixes: #34576
    
    PR-URL: #34578
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Pranshu Srivastava <rexagod@gmail.com>
    ronag authored and codebytere committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    7322e58 View commit details
    Browse the repository at this point in the history
  25. doc: add DerekNonGeneric to collaborators

    Fixes: #34369
    
    PR-URL: #34602
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Derek Lewis authored and codebytere committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    10dd7a0 View commit details
    Browse the repository at this point in the history
  26. doc: mention null special-case for napi_typeof

    The documentation said `napi_typeof` is similar to the `typeof`
    operator, but the `typeof null` detects `'object'` while
    `napi_typeof(a_null_value)` detects `napi_null`.
    
    PR-URL: #34577
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    goto-bus-stop authored and codebytere committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    0a9389b View commit details
    Browse the repository at this point in the history
  27. async_hooks: execute destroy hooks earlier

    Use a microtask to call destroy hooks in case there are a lot queued
    as immediate may be scheduled late in case of long running
    promise chains.
    
    Queuing a mircrotasks in GC context is not allowed therefore an
    interrupt is triggered to do this in JS context as fast as possible.
    
    fixes: #34328
    refs: #33896
    
    PR-URL: #34342
    Fixes: #34328
    Refs: #33896
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Flarna authored and codebytere committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    9af6264 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2020

  1. async_hooks: fix resource stack for deep stacks

    460c81d introduced a bug where the execution resource was not
    stored properly if we needed to call into C++ to extend the stack size.
    Fix that bug by always storing the resource.
    
    Refs: #34319
    Fixes: #34556
    
    PR-URL: #34573
    Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: Gus Caplan <me@gus.host>
    addaleax authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    7c4e1db View commit details
    Browse the repository at this point in the history
  2. test: fix flaky http-parser-timeout-reset

    Refs: #34578 (comment)
    
    PR-URL: #34609
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    ronag authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    283f5c3 View commit details
    Browse the repository at this point in the history
  3. doc: document the connection event for HTTP2 & TLS servers

    PR-URL: #34531
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    pimterry authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    1b0d3b2 View commit details
    Browse the repository at this point in the history
  4. test: change Fixes: to Refs:

    Tests don't fix things generally, so use "Refs:" to refer people to
    GitHub issues.
    
    PR-URL: #34568
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    dba869e View commit details
    Browse the repository at this point in the history
  5. async_hooks: fix id assignment in fast-path promise hook

    Native side of fast-path promise hook was not calling JS
    fastPromiseHook function when there were no async ids
    previously assigned to the promise. Because of that already
    created promises could not get id assigned in situations
    when an async hook without a before listener function is
    enabled after their creation. As the result executionAsyncId
    could return wrong id when called within promise's .then().
    
    Refs: #34512
    
    PR-URL: #34548
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    puzpuzpuz authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    18ca52d View commit details
    Browse the repository at this point in the history
  6. tools: add meta.fixable to fixable lint rules

    This commit adds the meta.fixable property to all fixable ESLint
    rules. This is required as of ESLint 7.6.0.
    
    PR-URL: #34589
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    cjihrig authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    2d2ea99 View commit details
    Browse the repository at this point in the history
  7. tools: update ESLint to 7.6.0

    Update ESLint to 7.6.0
    
    PR-URL: #34589
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    cjihrig authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    72f357a View commit details
    Browse the repository at this point in the history
  8. repl: give repl entries unique names

    This is a workaround for the REPL for a problem when multiple of the
    entries have the same source text
    
    Fixes: #1337
    Refs: https://bugs.chromium.org/p/v8/issues/detail?id=10284
    
    PR-URL: #34372
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    bmeck authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    ae64ec4 View commit details
    Browse the repository at this point in the history
  9. test: replace flaky pummel regression tests

    These tests were written a long time ago, and use the allocation of
    large amounts of unused memory as a way to detect use-after-free
    problems with Buffers. As a result, the tests are resource-intensive
    and may crash because of that.
    
    Replace them with a more modern test. We don’t explicitly try to
    *detect* use-after-free conditions, and instead rely on e.g. ASAN
    (or the process just crashing hard) to do that for us.
    
    Fixes: #34527
    
    PR-URL: #34530
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    addaleax authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    d6b0a40 View commit details
    Browse the repository at this point in the history
  10. doc: clarify process.title inconsistencies

    Many users assume the act of assigning a value to `process.title` will
    update the name of their application in apps like macOS Activity Monitor
    or Windows Services Manager. This has worked in the past, but fails in
    some versions of Node.js. Ultimately developers are left confused,
    especially when it works in one version of Node.js and not another.
    Given the recurring nature and complexity of the underlying problem, it
    does not seem like a resolvable problem. This note clarifies the source
    of the problem, sets developer expectations.
    
    Refs: #28945
    PR-URL: #34557
    Fixes: #34280
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    coreybutler authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    d972c54 View commit details
    Browse the repository at this point in the history
  11. doc: add release key for Ruy Adorno

    Add Ruy Adorno and his Release key.
    
    Refs: nodejs/Release#597
    
    PR-URL: #34628
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    ruyadorno authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    ba137e0 View commit details
    Browse the repository at this point in the history
  12. repl: improve static import error message in repl

    Currently the error is rather ambiguous and does not inform folks that
    static import is not supported in the repl. This overrides the default
    error message with one that is more informative.
    
    Closes: #33576
    
    PR-URL: #33588
    Fixes: #33576
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Guy Bedford <guybedford@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    MylesBorins authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    938842e View commit details
    Browse the repository at this point in the history
  13. build: increase startCI verbosity and fix job name

    Ref: #34594 (comment)
    
    PR-URL: #34635
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    mmarchini authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    338994f View commit details
    Browse the repository at this point in the history
  14. policy: increase tests via permutation matrix

    PR-URL: #34404
    Reviewed-By: James M Snell <jasnell@gmail.com>
    bmeck authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    3eabb7e View commit details
    Browse the repository at this point in the history
  15. test: convert most N-API tests from C++ to C

    * Prefix functions with `static` to make them local
    * Remove anonymous namespaces
    * `nullptr` -> `NULL`
    * .cc -> .c and update binding.gyp
    * `static_cast<x>()` -> `(x)()`
    * Replace `new`/`delete` with `malloc()`/`free()`
      (only in test_callback_scope)
    * Move lambda out and convert to local function
      (only in test_callback_scope)
    * Remove superfluous `#include <vector>`
      (only in test_callback_scope_recurse)
    
    Some tests are best left as C++.
    
    ```bash
    ls -l test/{node-api,js-native-api}/*/*.cc
    ```
    
    for those remaining as C++ tests.
    
    Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
    PR-URL: #34615
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Gabriel Schulhof authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    7be68cd View commit details
    Browse the repository at this point in the history
  16. module: unflag Top-Level Await

    This unflags Top-Level await so it can be used by default in the module
    goal. This is accomplished by manually setting the
    --harmony-top-level-await flag. We are allowing this as a one of
    approval based on circumstances. It is not a precedent that future
    harmony features will be manually enabled.
    
    Refs: #34551
    
    PR-URL: #34558
    Reviewed-By: Mary Marchini <oss@mmarchini.me>
    Reviewed-By: Zeyu Yang <himself65@outlook.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    MylesBorins authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    d0a599a View commit details
    Browse the repository at this point in the history
  17. module: handle Top-Level Await non-fulfills better

    Handle situations in which the main `Promise` from a TLA module
    is not fulfilled better:
    
    - When not resolving the `Promise` at all, set a non-zero exit code
      (unless another one has been requested explicitly) to distinguish
      the result from a successful completion.
    - When rejecting the `Promise`, always treat it like an uncaught
      exception. In particular, this also ensures a non-zero exit code.
    
    Refs: #34558
    
    PR-URL: #34640
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Guy Bedford <guybedford@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    addaleax authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    c21e62f View commit details
    Browse the repository at this point in the history
  18. build: enable build for node-v8 push

    PR-URL: #34634
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Mary Marchini <oss@mmarchini.me>
    gengjiawen authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    22f499f View commit details
    Browse the repository at this point in the history
  19. build: run CI on release branches

    PR-URL: #34649
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Mary Marchini <oss@mmarchini.me>
    codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    221802d View commit details
    Browse the repository at this point in the history
  20. async_hooks: don't read resource if ALS is disabled

    Only call executionAsyncResource() in getStore() if the ALS instance is
    enabled because the resource is not needed otherwise.
    
    PR-URL: #34617
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Flarna authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    4dbb931 View commit details
    Browse the repository at this point in the history
  21. meta: enable http2 team for CODEOWNERS

    PR-URL: #34534
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Trott authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    ffd2c7a View commit details
    Browse the repository at this point in the history
  22. crypto: add OP flag constants added in OpenSSL v1.1.1

    PR-URL: #33929
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Alba Mendez <me@alba.sh>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    mkrawczuk authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    a503470 View commit details
    Browse the repository at this point in the history
  23. doc: fix typo in path.md

    PR-URL: #34550
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    Reviewed-By: Zeyu Yang <himself65@outlook.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aetheryx authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    a0caf8c View commit details
    Browse the repository at this point in the history
  24. doc: update fs.watch() availability for IBM i

    Add a line that IBM i does not support `fs.watch()`.
    
    Fixes: #34607
    Refs: https://nodejs.org/docs/latest/api/fs.html#fs_availability
    
    PR-URL: #34611
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    iandrc authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    767a5cb View commit details
    Browse the repository at this point in the history
  25. test: add debugging for test-https-foafssl.js

    The test is timing out once in a very long while on Windows CI. It is
    unclear where the test gets stuck, so add more debugging statements to
    try to locate it.
    
    Refs: #24397
    
    PR-URL: #34603
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    4cd9c4f View commit details
    Browse the repository at this point in the history
  26. test: add debugging for callbacks in test-https-foafssl.js

    The test is timing out once in a very long while on Windows CI. It is
    unclear where the test gets stuck, so add more debugging statements to
    try to locate it.
    
    Refs: #24397
    
    PR-URL: #34603
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    27333b1 View commit details
    Browse the repository at this point in the history
  27. doc: edit process.title note for brevity and clarity

    PR-URL: #34627
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    7b4d40c View commit details
    Browse the repository at this point in the history
  28. deps: update to uvwasi 0.0.10

    Notable changes:
    
    - The uvwasi_preopen_t now uses const char* for the mapped_path
      and real_path fields. Previously, these were not `const`.
    - uvwasi_path_filestat_get() now properly handles the
      UVWASI_LOOKUP_SYMLINK_FOLLOW flag.
    - uvwasi_options_init() has been added to reduce the boilerplate
      code associated with initializing uvwasi_options_t's.
    - The DEBUG() macro has been renamed to UVWASI_DEBUG() to reduce
      naming conflicts with other projects.
    - A compilation error on NetBSD 8.2 has been fixed.
    - The uvwasi_fd_filestat_set_times() and
      uvwasi_path_filestat_set_times() functions now have proper
      implementations.
    
    Fixes: #34510
    
    PR-URL: #34623
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    cjihrig authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    8ff9caa View commit details
    Browse the repository at this point in the history
  29. wasi: add __wasi_fd_filestat_set_times() test

    PR-URL: #34623
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    cjihrig authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    c4d373b View commit details
    Browse the repository at this point in the history
  30. src: fix size underflow in CallbackQueue

    Only decrease the size when actually removing items.
    
    PR-URL: #34662
    Fixes: #34657
    Refs: #34572
    Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    addaleax authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    3132878 View commit details
    Browse the repository at this point in the history
  31. src: spin shutdown loop while immediates are pending

    This allows using `SetImmediate()` and friends at any point
    during cleanup.
    
    PR-URL: #34662
    Fixes: #34657
    Refs: #34572
    Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    addaleax authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    4369c2a View commit details
    Browse the repository at this point in the history
  32. build: do not run auto-start-ci on forks

    Previously, the auto-start-ci action would run on forks.
    Without the secrets, the action would fail over and over again.
    This caused a lot of email spam. Now, we only run this action
    when the repository is nodejs/node.
    
    PR-URL: #34650
    Reviewed-By: Mary Marchini <oss@mmarchini.me>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    evanlucas authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    f0b364f View commit details
    Browse the repository at this point in the history
  33. doc: add Ricky Zhou to collaborators

    PR-URL: #34676
    Fixes: #34441
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Mary Marchini <oss@mmarchini.me>
    rickyes authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    df8f9a4 View commit details
    Browse the repository at this point in the history
  34. test: fix wrong method call

    PR-URL: #34629
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    gengjiawen authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    33777a3 View commit details
    Browse the repository at this point in the history
  35. repl: use _REPL_ in user-facing text

    User-facing error messages should use _REPL_ for the general REPL and
    not _repl_ which should be reserved for referring to the module itself,
    etc. _REPL_ is an acronym, so it should be capitalized, as it generally
    is in documentation in other technologies, and is usually in our own
    documentation. This fixes a few inconsistent usages in lib/repl.js.
    
    PR-URL: #34643
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Trott authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    3ecb16b View commit details
    Browse the repository at this point in the history
  36. net: don't return the stream object from onStreamRead

    CallJSOnreadMethod expects the return value to be undefined or
    a new buffer, so make sure to return nothing, even when an error
    causes us to destroy the stream.
    
    Fixes: #34346
    
    PR-URL: #34375
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    robey authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    7887ce2 View commit details
    Browse the repository at this point in the history
  37. repl: use _Node.js_ in user-facing REPL text

    We use _node (REPL)_ in one place and _Node.js (REPL)_ in another place
    in error messages in repl.js. Use _Node.js_ in both places.
    
    PR-URL: #34644
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Trott authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    0c4226e View commit details
    Browse the repository at this point in the history
  38. async_hooks: add AsyncResource.bind utility

    Creates an internal AsyncResource and binds a function to it,
    ensuring that the function is invoked within execution context
    in which bind was called.
    
    PR-URL: #34574
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    jasnell authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    ef4fb68 View commit details
    Browse the repository at this point in the history
  39. async_hooks: improve property descriptors in als.bind

    The length property should be non enumerable to match behavior of
    normal functions.
    
    The asyncResource property is enumerable and therefore it should be
    also writable to avoid issues like there:
    #30932 (comment)
    
    Both properties should be configurable.
    
    Refs: #34574
    
    PR-URL: #34620
    Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Flarna authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    0730c76 View commit details
    Browse the repository at this point in the history
  40. async_hooks: avoid unneeded AsyncResource creation

    Inspired by the callstack at #34556 (comment)
    
    If the wanted store is equal to the active store it's not needed to
    create an AsyncResource.
    
    Refs: #34556 (comment)
    
    PR-URL: #34616
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
    Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
    Flarna authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    641a5fb View commit details
    Browse the repository at this point in the history
  41. n-api,src: provide asynchronous cleanup hooks

    Sometimes addons need to perform cleanup actions, for example
    closing libuv handles or waiting for requests to finish, that
    cannot be performed synchronously.
    
    Add C++ API and N-API functions that allow providing such
    asynchronous cleanup hooks.
    
    Fixes: #34567
    
    PR-URL: #34572
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
    addaleax authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    8630f34 View commit details
    Browse the repository at this point in the history
  42. async_hooks: avoid GC tracking of AsyncResource in ALS

    Manually destroy the AsyncResource created by AsyncLocalStore.run() to
    avoid unneeded GC tracking in case a destroy hooks is present.
    
    PR-URL: #34653
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Flarna authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    db6f9bd View commit details
    Browse the repository at this point in the history
  43. n-api: fix use-after-free with napi_remove_async_cleanup_hook

    Fixes: #34657
    Refs: #34572
    
    PR-URL: #34662
    Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    addaleax authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    4ed89a3 View commit details
    Browse the repository at this point in the history
  44. doc: use _Class Method_ in async_hooks.md

    We use _Class Method_ rather than _static_ in documentation headers in
    buffer.md and crypto.md.  We use _static_ in one place in
    async_hooks.md. Change to _Class Method_ for consistency.
    
    PR-URL: #34626
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Trott authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    a944dab View commit details
    Browse the repository at this point in the history
  45. src: fix linter failures

    Fix linter failures when running the linter on all source files.
    
    PR-URL: #34582
    Refs: #34565
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    addaleax authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    e97fe4b View commit details
    Browse the repository at this point in the history
  46. tools: fix C++ import checker argument expansion

    Makefile assumes that it can pass a list of files to the import
    checker, whereas the import checker expects a single argument
    that is interpreted as a blob.
    
    Fix that mismatch by accepting multiple arguments in the import
    checker.
    
    Refs: #34565
    
    PR-URL: #34582
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    addaleax authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    af0cfeb View commit details
    Browse the repository at this point in the history
  47. doc: tidy some addons.md text

    PR-URL: #34654
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    5b5f5f9 View commit details
    Browse the repository at this point in the history
  48. lib: use non-symbols in isURLInstance check

    PR-URL: #34622
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    4efc5f6 View commit details
    Browse the repository at this point in the history
  49. doc: use _Static method_ instead of _Class Method_

    Our docs describe static methods as Class Methods which seems
    idiosyncratic for JavaScript. Align with MDN which calls them static
    methods.
    
    Refs: https://developer.mozilla.org/en-US/docs/MDN/Contribute/Structures/API_references/What_does_an_API_reference_need
    
    JSON format for our docs will still use the key name `classMethods` for
    this. I would like to change it to `staticMethods` but I don't know if
    that will break things for consumers. So, leaving it alone. It's a
    machine-consumable label more than a human-readable so I can live with
    that.
    
    PR-URL: #34659
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Trott authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    41d0cf7 View commit details
    Browse the repository at this point in the history
  50. meta: uncomment all codeowners

    A recent feature was added to github-bot to ping codeowners defined on
    the CODEOWNERS file even if the team doesn't have write permission to
    the repository. That means we can enable codeowners everywhere in the
    repository.
    
    Ref: nodejs/github-bot#265
    Fix: #33984
    
    PR-URL: #34670
    Fixes: #33984
    Refs: nodejs/github-bot#265
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    mmarchini authored and codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    bd00f26 View commit details
    Browse the repository at this point in the history
  51. 2020-08-11, Version 14.8.0 (Current)

    Notable changes:
    
    async_hooks:
      * (SEMVER-MINOR) add AsyncResource.bind utility (James M Snell) #34574
    doc:
      * add Ricky Zhou to collaborators (rickyes) #34676
      * add release key for Ruy Adorno (Ruy Adorno) #34628
      * add DerekNonGeneric to collaborators (Derek Lewis) #34602
    module:
      * (SEMVER-MINOR) unflag Top-Level Await (Myles Borins) #34558
    n-api:
      * (SEMVER-MINOR) support type-tagging objects (Gabriel Schulhof) #28237
    n-api,src:
      * (SEMVER-MINOR) provide asynchronous cleanup hooks (Anna Henningsen) #34572
    
    PR-URL: #34704
    codebytere committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    b45ea94 View commit details
    Browse the repository at this point in the history