Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove unneeded flag check in test-vm-memleak #34528

Closed
wants to merge 0 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 27, 2020

The common module checks that necessary flags are being used, so a
check in the test itself is no longer necessary.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 27, 2020
@Trott Trott requested a review from BridgeAR July 27, 2020 05:55
@Trott
Copy link
Member Author

Trott commented Jul 30, 2020

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 30, 2020
Trott added a commit to Trott/io.js that referenced this pull request Jul 30, 2020
The `common` module checks that necessary flags are being used, so a
check in the test itself is no longer necessary.

PR-URL: nodejs#34528
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott
Copy link
Member Author

Trott commented Jul 30, 2020

Landed in 2d2a812

@Trott Trott closed this Jul 30, 2020
@Trott Trott deleted the no-check branch July 30, 2020 19:55
codebytere pushed a commit that referenced this pull request Aug 5, 2020
The `common` module checks that necessary flags are being used, so a
check in the test itself is no longer necessary.

PR-URL: #34528
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebytere codebytere mentioned this pull request Aug 10, 2020
addaleax pushed a commit that referenced this pull request Sep 22, 2020
The `common` module checks that necessary flags are being used, so a
check in the test itself is no longer necessary.

PR-URL: #34528
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
The `common` module checks that necessary flags are being used, so a
check in the test itself is no longer necessary.

PR-URL: #34528
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants