Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert: add tests to assert and improve coverage #28355

Closed
wants to merge 4 commits into from
Closed

assert: add tests to assert and improve coverage #28355

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5e970a1
Improve coverage for assert.ok
estrada9166 Jun 21, 2019
4a4f668
test: add tests to assert.ok
estrada9166 Jun 23, 2019
62084f4
assert: add tests to assert.ok and improve coverage
estrada9166 Jun 23, 2019
e8077eb
assert: add test to doesNotThrow; validate if actual with regex.
estrada9166 Jun 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions test/parallel/test-assert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,19 @@ assert.ok(a.AssertionError.prototype instanceof Error,
assert.throws(() => a(false), a.AssertionError, 'ok(false)');
assert.throws(() => a.ok(false), a.AssertionError, 'ok(false)');

// Throw message if the message is instanceof Error.
{
let threw = false;
try {
assert.ok(false, new Error('ok(false)'));
} catch (e) {
threw = true;
assert.ok(e instanceof Error);
}
assert.ok(threw, 'Error: ok(false)');
}


a(true);
a('test', 'ok(\'test\')');
a.ok(true);
Expand Down Expand Up @@ -165,6 +178,17 @@ assert.throws(
}
);

assert.throws(
() => a.doesNotThrow(() => thrower(Error), /\[[a-z]{6}\s[A-z]{6}\]/g, 'user message'),
{
name: 'AssertionError',
code: 'ERR_ASSERTION',
operator: 'doesNotThrow',
message: 'Got unwanted exception: user message\n' +
'Actual message: "[object Object]"'
}
);

// Make sure that validating using constructor really works.
{
let threw = false;
Expand Down