Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert: add tests to assert and improve coverage #28355

Closed
wants to merge 4 commits into from
Closed

assert: add tests to assert and improve coverage #28355

wants to merge 4 commits into from

Conversation

estrada9166
Copy link
Contributor

@estrada9166 estrada9166 commented Jun 21, 2019 •
edited
Loading

Improve code coverage for assert.ok

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jun 21, 2019
Trott
Trott reviewed Jun 22, 2019
View reviewed changes
test/parallel/test-assert.js Outdated Show resolved Hide resolved
@jasnell jasnell added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Jun 23, 2019
@estrada9166
Copy link
Contributor Author

Sorry, for the force-push, I was trying to fix the commit message to make it pass on the ci, but it still says Missing subsystem. but it's linked to the first commit. How can I fix it?

@estrada9166 estrada9166 changed the title Improve coverage for assert.ok assert: add tests to assert.ok and improve coverage Jun 24, 2019
@estrada9166 estrada9166 changed the title assert: add tests to assert.ok and improve coverage assert: add tests to assert and improve coverage Jun 24, 2019
@Trott
Copy link
Member

Trott commented Jun 24, 2019

Sorry, for the force-push, I was trying to fix the commit message to make it pass on the ci, but it still says Missing subsystem. but it's linked to the first commit. How can I fix it?

Don't worry about it. Whoever lands this can fix up the commit message!

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24079/

@addaleax
Copy link
Member

addaleax commented Jul 1, 2019

Landed in 6e9d795 and 367ada4, thanks for the contribution! 🎉

@addaleax addaleax closed this Jul 1, 2019
addaleax pushed a commit that referenced this pull request Jul 1, 2019
@estrada9166 @addaleax
test: add tests to assert.ok and improve coverage
6e9d795 
Refs: https://coverage.nodejs.org/coverage-1a4f27ae21698d0c/lib/assert.js.html#L364

PR-URL: #28355
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
addaleax pushed a commit that referenced this pull request Jul 1, 2019
@estrada9166 @addaleax
test: add test to doesNotThrow; validate if actual with regex
367ada4 
Refs: https://coverage.nodejs.org/coverage-1a4f27ae21698d0c/lib/assert.js.html#L736

PR-URL: #28355
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Jul 2, 2019
@estrada9166 @targos
test: add tests to assert.ok and improve coverage
bf13a25 
Refs: https://coverage.nodejs.org/coverage-1a4f27ae21698d0c/lib/assert.js.html#L364

PR-URL: #28355
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Jul 2, 2019
@estrada9166 @targos
test: add test to doesNotThrow; validate if actual with regex
91502a7 
Refs: https://coverage.nodejs.org/coverage-1a4f27ae21698d0c/lib/assert.js.html#L736

PR-URL: #28355
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Jul 2, 2019
@estrada9166 @targos
test: add tests to assert.ok and improve coverage
004d26d 
Refs: https://coverage.nodejs.org/coverage-1a4f27ae21698d0c/lib/assert.js.html#L364

PR-URL: #28355
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Jul 2, 2019
@estrada9166 @targos
test: add test to doesNotThrow; validate if actual with regex
937afcc 
Refs: https://coverage.nodejs.org/coverage-1a4f27ae21698d0c/lib/assert.js.html#L736

PR-URL: #28355
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Jul 2, 2019
Merged
This was referenced Jul 3, 2019
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@estrada9166 @Trott @nodejs-github-bot @addaleax @jasnell @cjihrig @trivikr