Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to v1.x #1736

Closed
wants to merge 48 commits into from
Closed

Commits on May 19, 2015

  1. buffer: little improve for Buffer.concat method

    When buffer list less than 2, no need to calculate the length.
    The change's benchmark result is here:
    https://gist.github.com/JacksonTian/2c9e2bdec00018e010e6
    It improve 15% ~ 25% speed when list only have one buffer,
    to other cases no effect.
    
    PR-URL: nodejs#1437
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
    JacksonTian authored and Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    fa105ab View commit details
    Browse the repository at this point in the history
  2. src: fix NODE_DEPRECATED macro

    The NODE_DEPRECATED macro was piggybacking on the V8_DEPRECATED macro
    but that macro is silent unless V8_DEPRECATION_WARNINGS is defined,
    something io.js doesn't do.  Ergo, no deprecation notices were being
    issued.
    
    PR-URL: nodejs#1565
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    bnoordhuis authored and Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    1ab65e4 View commit details
    Browse the repository at this point in the history
  3. src: fix deprecation warnings

    The previous commit enables deprecation warnings, this commit fixes
    the handful of offending sites where the isolate was not explicitly
    being passed around.
    
    PR-URL: nodejs#1565
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    bnoordhuis authored and Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    3c9f63f View commit details
    Browse the repository at this point in the history
  4. gitignore: ignore xcode workspaces and projects

    Calling ./configure --xcode creates xcode projects and a
    workspace for io.js.
    
    PR-URL: nodejs#1562
    Reviewed-By: Vladimir Kurchatkin <vladimir.kurchatkin@gmail.com>
    Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Roman Reiss <me@silverwind.io>
    r-52 authored and Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    a76b6ba View commit details
    Browse the repository at this point in the history
  5. build: Use option groups in configure output

    Minor edits to current build flags and its help texts as well
    as grouping shared and i18n options into separate option groups.
    
    Also, validate i18n default/logic similar to how we treat other
    options. `--download` isn't really intl-specific but is only used
    for that purpose which is why it's grouped similarly.
    
    PR-URL: nodejs#1533
    Reviewed-By: Rod Vagg <rod@vagg.org>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Steven R. Loomis <srl@icu-project.org>
    jbergstroem authored and Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    91da332 View commit details
    Browse the repository at this point in the history
  6. build: move --with-intl to intl optgroup

    PR-URL: nodejs#1680
    Reviewed-By: Rod Vagg <rod@vagg.org>
    jbergstroem authored and Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    f6d7de1 View commit details
    Browse the repository at this point in the history
  7. stream_base: dispatch reqs in the stream impl

    Dispatch requests in the implementation of the stream, not in the code
    creating these requests. The requests might be piled up and invoked
    internally in the implementation, so it should know better when it is
    the time to dispatch them.
    
    In fact, TLS was doing exactly this thing which led us to...
    
    Fix: nodejs#1512
    PR-URL: nodejs#1563
    Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
    indutny authored and Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    c5d7c7e View commit details
    Browse the repository at this point in the history
  8. tls: use SSL_set_cert_cb for async SNI/OCSP

    Do not enable ClientHello parser for async SNI/OCSP. Use new
    OpenSSL-1.0.2's API `SSL_set_cert_cb` to pause the handshake process and
    load the cert/OCSP response asynchronously. Hopefuly this will make
    whole async SNI/OCSP process much faster and will eventually let us
    remove the ClientHello parser itself (which is currently used only for
    async session, see nodejs#1462 for the discussion of removing it).
    
    NOTE: Ported our code to `SSL_CTX_add1_chain_cert` to use
    `SSL_CTX_get0_chain_certs` in `CertCbDone`. Test provided for this
    feature.
    
    Fix: nodejs#1423
    PR-URL: nodejs#1464
    Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
    indutny authored and Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    592230a View commit details
    Browse the repository at this point in the history
  9. node: improve nextTick performance

    This commit uses separate functions to isolate deopts caused by
    try-catches and avoids fn.apply() for callbacks with small numbers
    of arguments.
    
    These changes improve performance by ~1-40% in the various
    nextTick benchmarks.
    
    PR-URL: nodejs#1571
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
    mscdex authored and Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    908643d View commit details
    Browse the repository at this point in the history
  10. net: ensure Write/ShutdownWrap references handle

    `StreamBase::AfterWrite` is passing handle as an argument to the
    `afterWrite` function in net.js. Thus GC should not collect the handle
    and the request separately and assume that they are tied together.
    
    With this commit - request will always outlive the StreamBase instance,
    helping us survive the GC pass.
    
    Same applies to the ShutdownWrap instances, they should never be
    collected after the StreamBase instance.
    
    Fix: nodejs#1580
    PR-URL: nodejs#1590
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    indutny authored and Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    26760a9 View commit details
    Browse the repository at this point in the history
  11. tls_wrap: Unlink TLSWrap and SecureContext objects

    This makes `TLSWrap` and `SecureContext` objects collectable by the
    incremental gc.
    
    `res = null` destroys the cyclic reference in the `reading` property.
    `this.ssl = null` removes the remaining reference to the `TLSWrap`.
    `this.ssl._secureContext.context = null` removes the reference to
    the `SecureContext` object, even though there might be references
    to `this.ssl._secureContext` somewhere.
    
    The `reading` property will now throw an error if accessed after the
    socket is closed, but that should not happen.
    
    PR-URL: nodejs#1580
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
    ChALkeR authored and Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    dedddb7 View commit details
    Browse the repository at this point in the history
  12. src: fix -Wmissing-field-initializers warning

    Fix the following (non-serious) compiler warning:
    
        ../src/node_http_parser.cc:558:1: warning: missing initializer for
        member 'http_parser_settings::on_chunk_header'
        [-Wmissing-field-initializers]
        };
        ^
        ../src/node_http_parser.cc:558:1: warning: missing initializer for
        member 'http_parser_settings::on_chunk_complete'
        [-Wmissing-field-initializers]
    
    Introduced in commit b3a7da1 ("deps: update http_parser to 2.5.0").
    
    PR-URL: nodejs#1606
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    bnoordhuis authored and Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    6568dc9 View commit details
    Browse the repository at this point in the history
  13. async-wrap: don't call init callback unnecessarily

    Some calls to ReqWrap would get through the initial check and allow the
    init callback to run, even though the callback had not been used on the
    parent. Fix by explicitly checking if the parent has a queue.
    
    Also change the name of the check, and internal field of AsyncHooks.
    Other names were confusing.
    
    PR-URL: nodejs#1614
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    trevnorris authored and Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    a2b6650 View commit details
    Browse the repository at this point in the history
  14. async-wrap: pass PROVIDER as first arg to init

    Allow the init callback to see the PROVIDER type easily by being able to
    compare the flag with the list of providers on the exported async_wrap
    object.
    
    PR-URL: nodejs#1614
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    trevnorris authored and Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    c8b05e4 View commit details
    Browse the repository at this point in the history
  15. async-wrap: set flags using functions

    Setting flags using cryptic numeric object fields is confusing. Instead
    use much simpler .enable()/.disable() calls on the async_wrap object.
    
    PR-URL: nodejs#1614
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    trevnorris authored and Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    a703e07 View commit details
    Browse the repository at this point in the history
  16. async-wrap: remove before/after calls in init

    It doesn't make sense to call before/after callbacks in init to the
    parent because they'll be made anyway from MakeCallback. If information
    does need to be propagated then it should be done automatically. Will
    deal with this if the issue arrises in the future.
    
    PR-URL: nodejs#1614
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    trevnorris authored and Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    54ae094 View commit details
    Browse the repository at this point in the history
  17. src: fix NODE_DEPRECATED macro with old compilers

    The `__attribute__((deprecated("warning")))` macro didn't exist until
    gcc 4.5 and clang 2.9.
    
    While io.js does not build with compilers that old, add-ons do.  Let's
    make src/node.h compatible with such compilers, it's a public header.
    
    PR-URL: nodejs#1626
    Refs: nodejs#1619
    Reviewed-By: Rod Vagg <rod@vagg.org>
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    bnoordhuis authored and Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    d90eadc View commit details
    Browse the repository at this point in the history
  18. src: fix pedantic cpplint whitespace warnings

    Introduced in commit b712af7 ("src: fix NODE_DEPRECATED macro with old
    compilers").
    
    PR-URL: nodejs#1640
    Reviewed-By: Roman Reiss <me@silverwind.io>
    bnoordhuis authored and Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    df389c6 View commit details
    Browse the repository at this point in the history
  19. js_stream: fix buffer index in DoWrite

    The index of buffer to write in JSStream was always 0 by mistake. This
    fix was to use increment index of buffer arrays.
    The test was originally made by Brian White in nodejs#1594.
    
    Fix: nodejs#1595
    Fix: nodejs#1594
    PR-URL: nodejs#1635
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    Shigeki Ohtsu authored and Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    46561fc View commit details
    Browse the repository at this point in the history
  20. deps: update libuv to 1.5.0

    Fixes: nodejs#1397
    Fixes: nodejs#1512
    Fixes: nodejs#1621
    Fixes: nodejs#862
    PR-URL: nodejs#1646
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    saghul authored and Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    8651ecc View commit details
    Browse the repository at this point in the history
  21. src: export the ParseEncoding function on Windows

    Makes the ParseEncoding symbol visible to addons on Windows.
    It was already visible on Unices.
    
    PR-URL: nodejs#1596
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    ivan authored and Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    98b1109 View commit details
    Browse the repository at this point in the history
  22. install: fix NameError

    If `len(args)` is less than two, then
    `install_path = dst_dir + node_prefix + '/'` would throw a `NameError`,
    because `dst_dir` will not be defined yet. So we are assigning `''` as
    the default value.
    
    PR-URL: nodejs#1628
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    thefourtheye authored and Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    e628b19 View commit details
    Browse the repository at this point in the history
  23. src: add type check to v8.setFlagsFromString()

    Calling v8.setFlagsFromString with e.g a function as a flag argument
    gave no exception or warning that the function call will fail.
    
    There is now an exception if the function gets called with the wrong
    flag type (string is required) or that a flag is expected.
    
    Other APIs already provide exceptions if the argument has not the
    expected type.
    
    PR-URL: nodejs#1652
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    r-52 authored and Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    e42dcc2 View commit details
    Browse the repository at this point in the history
  24. cluster: disconnect event not emitted correctly

    Inside of a worker, disconnect event was not emitted on cluster.worker
    
    Fixes: nodejs#1304
    PR-URL: nodejs#1386
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Olegas authored and Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    ebc671b View commit details
    Browse the repository at this point in the history
  25. tools: replace closure-linter with eslint

    PR-URL: nodejs#1539
    Fixes: nodejs#1253
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    Reviewed-By: Roman Reiss <me@silverwind.io>
    Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
    Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
    Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
    yosuke-furukawa authored and Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    367e221 View commit details
    Browse the repository at this point in the history
  26. lib: fix eslint styles

    PR-URL: nodejs#1539
    Fixes: nodejs#1253
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    Reviewed-By: Roman Reiss <me@silverwind.io>
    Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
    Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
    Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
    yosuke-furukawa authored and Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    edb4cb6 View commit details
    Browse the repository at this point in the history
  27. tools: remove closure_linter to eslint on windows

    PR-URL: nodejs#1685
    Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
    Reviewed-By: Roman Reiss <me@silverwind.io>
    Yosuke Furukawa authored and Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    82a5dab View commit details
    Browse the repository at this point in the history
  28. tools: set eslint comma-spacing to 'warn'

    Certain cases with comments inside arrays or object literals fail to
    pass eslint's comma-spacing rule. This change sets the comma-spacing
    rule to the 'warn' level.
    
    Once eslint/eslint#2408 is resolved and
    released, this rule should be set back to 'error' level.
    
    PR-URL: nodejs#1672
    Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
    silverwind authored and Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    ecb2436 View commit details
    Browse the repository at this point in the history
  29. tools: make eslint work on subdirectories

    The old pattern didn't include files in lib/internal. This changes the
    pattern to directories which makes eslint apply to all subdirectories as
    well.
    
    PR-URL: nodejs#1686
    Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
    silverwind authored and Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    91a9c6d View commit details
    Browse the repository at this point in the history
  30. readline: turn emitKeys into a streaming parser

    In certain environments escape sequences could be splitted into
    multiple chunks. For example, when user presses left arrow,
    `\x1b[D` sequence could appear as two keypresses (`\x1b` + `[D`).
    
    PR-URL: nodejs#1601
    Fixes: nodejs#1403
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Roman Reiss <me@silverwind.io>
    rlidwka authored and Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    c212f8e View commit details
    Browse the repository at this point in the history
  31. dgram: call send callback asynchronously

    dgram#send callback was changed synchronously.
    The PR-URL is here joyent/libuv#1358
    
    This commit is temporary fix until libuv issue is resolved.
    libuv/libuv#301
    
    PR-URL: nodejs#1313
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    yosuke-furukawa authored and Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    e05afd7 View commit details
    Browse the repository at this point in the history
  32. test: fix infinite loop detection

    Fixes: nodejs#1675
    PR-URL: nodejs#1681
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Yosuke Furukawa authored and Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    e7427ae View commit details
    Browse the repository at this point in the history
  33. tls: update default ciphers to use gcm and aes128

    AES-GCM or CHACHA20_POLY1305 ciphers must be used in current version of
    Chrome to avoid an 'obsolete cryptography' warning.
    
    Prefer 128 bit AES over 192 and 256 bit AES considering attacks that
    specifically affect the larger key sizes but do not affect AES 128.
    
    PR-URL: nodejs#1660
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
    Reviewed-By: Roman Reiss <me@silverwind.io>
    Mike MacCana authored and Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    da99a94 View commit details
    Browse the repository at this point in the history
  34. build: re-enable V8 snapshots

    Snapshots had been previously disabled because of a security
    vunerability. This has been fixed (ref:
    nodejs#1631 (comment))
    
    Also, re-enable snapshots for ARMv6 builds. There were previous build
    issues that have been fixed.
    
    Fixes: nodejs#1631
    PR-URL: nodejs#1663
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    trevnorris authored and Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    05e61c7 View commit details
    Browse the repository at this point in the history
  35. deps: sync with upstream c-ares/c-ares@bba4dc5

    Fixes: nodejs#1676
    PR-URL: nodejs#1678
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    bnoordhuis authored and Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    8ebdb29 View commit details
    Browse the repository at this point in the history
  36. deps: provide TXT chunk info in c-ares

    Provide more information in `ares_txt_reply` to coalesce chunks from the
    same record into one string.
    
    fix nodejs#7367
    indutny authored and Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    570f2a3 View commit details
    Browse the repository at this point in the history
  37. src,deps: replace LoadLibrary by LoadLibraryW

    On Windows, when compiling with `UNICODE` defined, `LoadLibrary` becomes
    `LoadLibraryW`. When an ASCII string is passed to that function it
    crashes.
    
    PR-URL: nodejs#226
    Reviewed-By: Bert Belder <bertbelder@gmail.com>
    zcbenz authored and Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    887db51 View commit details
    Browse the repository at this point in the history
  38. events: provide better error message for unhandled error

    Previously, in the event of an unhandled error event, if the error is a
    not an actual Error, then a default error is thrown. Now, the argument
    is appended to the error message and added as the `context` property
    of the error.
    
    PR-URL: nodejs#1654
    Reviewed-By: Rod Vagg <rod@vagg.org>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    evanlucas authored and Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    69bc061 View commit details
    Browse the repository at this point in the history
  39. tools: refactor make test-npm into test-npm.sh

    Extracts test-npm from Makefile and puts it in tools/test-npm.sh
    Also improves test-npm to use a separate copy of deps/npm for testing.
    
    PR-URL: nodejs#1662
    Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    3416e93 View commit details
    Browse the repository at this point in the history
  40. build: use backslashes for paths on windows

    PR-URL: nodejs#1698
    Reviewed-By: Yosuke Furukawa <furukawa.yosuke@dena.jp>
    Reviewed-By: Roman Reiss <me@silverwind.io>
    jbergstroem authored and Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    c7eab79 View commit details
    Browse the repository at this point in the history
  41. src: fix preload when used with prior flags

    Fixes: nodejs#1691
    PR-URL: nodejs#1694
    Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    yosuke-furukawa authored and Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    df9aac8 View commit details
    Browse the repository at this point in the history
  42. tls: fix tls handshake check in ssl error

    In ssl.onerror event, `this` refers `ssl` so that
    `this._secureEstablished` is always undefined. Fix it to refer
    TLSSocket.
    
    PR-URL: nodejs#1661
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    Shigeki Ohtsu authored and Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    0e9be82 View commit details
    Browse the repository at this point in the history
  43. tls_wrap: fix error cb when fatal TLS Alert recvd

    SSL_read() returns 0 when fatal TLS Alert is received.
    Fix to invoke ssl error callback in this case.
    
    PR-URL: nodejs#1661
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    Shigeki Ohtsu authored and Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    4ba3d68 View commit details
    Browse the repository at this point in the history
  44. core: set PROVIDER type as Persistent class id

    Pass along the PROVIDER type, that is already passed to AsyncWrap, along
    to BaseObject to set the handle_'s class id. This will allow all
    Persistents to be transversed and uniquely identified by what type they
    are using APIs such as v8::PersistentHandleVisitor.
    
    PR-URL: nodejs#1730
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    trevnorris authored and Fishrock123 committed May 19, 2015
    Configuration menu
    Copy the full SHA
    575738b View commit details
    Browse the repository at this point in the history

Commits on May 21, 2015

  1. test: enable linting for tests

    Enable linting for the test directory. A number of changes was made so
    all tests conform the current rules used by lib and src directories. The
    only exception for tests is that unreachable (dead) code is allowed.
    
    test-fs-non-number-arguments-throw had to be excluded from the changes
    because of a weird issue on Windows CI.
    
    PR-URL: nodejs#1721
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    
    Conflicts:
    	test/parallel/test-arm-math-exp-regress-1376.js
    	test/parallel/test-net-dns-custom-lookup.js
    	test/parallel/test-net-dns-lookup-skip.js
    	test/parallel/test-repl-mode.js
    	test/parallel/test-repl-options.js
    	test/parallel/test-repl-tab.js
    	test/parallel/test-util-inspect.js
    silverwind authored and Fishrock123 committed May 21, 2015
    Configuration menu
    Copy the full SHA
    9f8a3a4 View commit details
    Browse the repository at this point in the history
  2. tls: make server not use DHE in less than 1024bits

    DHE key lengths less than 1024bits is already weaken as pointed out in
    https://weakdh.org/ . 1024bits will not be safe in near future. We
    will extend this up to 2048bits somedays later.
    
    PR-URL: nodejs#1739
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    Shigeki Ohtsu authored and Fishrock123 committed May 21, 2015
    Configuration menu
    Copy the full SHA
    f8e5eaa View commit details
    Browse the repository at this point in the history
  3. util: speed up common case of formatting string

    PR-URL: nodejs#1749
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    ChALkeR authored and Fishrock123 committed May 21, 2015
    Configuration menu
    Copy the full SHA
    0c6a548 View commit details
    Browse the repository at this point in the history
  4. build: refactor pkg-config for shared libraries

    Improve detection and usage of pkg-config. This simplifies the setup
    of all our shared libraries.
    
    If pkg-config is installed on the host and `--shared` flags are passed
    by the user, we try to get defaults from pkg-config instead of using the
    default provided by configure.
    
    PR-URL: nodejs#1603
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    jbergstroem authored and Fishrock123 committed May 21, 2015
    Configuration menu
    Copy the full SHA
    cb3326f View commit details
    Browse the repository at this point in the history