Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use backslashes for paths on windows #1698

Closed
wants to merge 1 commit into from

Conversation

jbergstroem
Copy link
Member

Minor fix on top of #1685.

/R=@silverwind, @yosuke-furukawa

@jbergstroem jbergstroem added windows Issues and PRs related to the Windows platform. build Issues and PRs related to build files or the CI. labels May 13, 2015
@yosuke-furukawa
Copy link
Member

LGTM

@silverwind
Copy link
Contributor

LGTM, too

jbergstroem added a commit that referenced this pull request May 14, 2015
PR-URL: #1698
Reviewed-By: Yosuke Furukawa <furukawa.yosuke@dena.jp>
Reviewed-By: Roman Reiss <me@silverwind.io>
@jbergstroem
Copy link
Member Author

Merged in 8a0e529. Closing.

Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request May 19, 2015
PR-URL: nodejs#1698
Reviewed-By: Yosuke Furukawa <furukawa.yosuke@dena.jp>
Reviewed-By: Roman Reiss <me@silverwind.io>
andrewdeandrade pushed a commit to andrewdeandrade/node that referenced this pull request Jun 3, 2015
PR-URL: nodejs/node#1698
Reviewed-By: Yosuke Furukawa <furukawa.yosuke@dena.jp>
Reviewed-By: Roman Reiss <me@silverwind.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants