Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace assert.throws() with common.expectsError() in test/parallel/next-tick-errors.js (take 2) #17091

Closed
wants to merge 6 commits into from
Closed

Replace assert.throws() with common.expectsError() in test/parallel/next-tick-errors.js (take 2) #17091

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
02bbedd
Merge remote-tracking branch 'upstream/master'
SethGreylyn Oct 26, 2017
589d628
Merge remote-tracking branch 'upstream/master'
SethGreylyn Nov 13, 2017
65e9e32
Merge remote-tracking branch 'upstream/master'
SethGreylyn Nov 15, 2017
723fc7d
Merge remote-tracking branch 'upstream/master'
SethGreylyn Nov 17, 2017
9b6a344
Merge remote-tracking branch 'upstream/master'
SethGreylyn Nov 17, 2017
5386aa1
test: replaced assert.throws() with common.expectsError()
SethGreylyn Nov 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions test/parallel/test-next-tick-errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
// USE OR OTHER DEALINGS IN THE SOFTWARE.

'use strict';
require('../common');
const common = require('../common');
const assert = require('assert');

const order = [];
Expand All @@ -42,11 +42,15 @@ process.nextTick(function() {
});

function testNextTickWith(val) {
assert.throws(
common.expectsError(
function() {
process.nextTick(val);
},
TypeError
{
code: 'ERR_INVALID_CALLBACK',
name: 'TypeError [ERR_INVALID_CALLBACK]',
type: TypeError
}
);
}

Expand Down