Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace assert.throws() with common.expectsError() in test/parallel/next-tick-errors.js (take 2) #17091

Closed
wants to merge 6 commits into from
Closed

Replace assert.throws() with common.expectsError() in test/parallel/next-tick-errors.js (take 2) #17091

wants to merge 6 commits into from

Conversation

SethGreylyn
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 17, 2017
@lpinca
Copy link
Member

lpinca commented Nov 18, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11512/

apapirovski pushed a commit to apapirovski/node that referenced this pull request Nov 20, 2017
@SethGreylyn @apapirovski
test: replace assert.throws w/ common.expectsError
5201055 
PR-URL: nodejs#17091
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@apapirovski
Copy link
Member

Landed in 5201055

@apapirovski
Copy link
Member

Congrats on becoming a Contributor @SethGreylyn! Thanks for helping us improve Node.js!! 🥇

@SethGreylyn
Copy link
Contributor Author

Thanks! I'm looking forward to contributing more!

MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@SethGreylyn @MylesBorins
test: replace assert.throws w/ common.expectsError
9914bca 
PR-URL: #17091
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@SethGreylyn @gibfahn
test: replace assert.throws w/ common.expectsError
88a5c13 
PR-URL: #17091
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@SethGreylyn @gibfahn
test: replace assert.throws w/ common.expectsError
c86f185 
PR-URL: #17091
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@SethGreylyn @lpinca @apapirovski @targos @cjihrig @gireeshpunathil @MylesBorins @gibfahn @nodejs-github-bot