Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: cherry-pick upstream ICU fix #16931

Closed
wants to merge 1 commit into from
Closed

deps: cherry-pick upstream ICU fix #16931

wants to merge 1 commit into from

Conversation

mathiasbynens
Copy link
Contributor

@mathiasbynens mathiasbynens commented Nov 10, 2017 •
edited
Loading

ICU 60.1 has a bug resulting in incorrect Script_Extensions data for 5 characters. http://bugs.icu-project.org/trac/ticket/13462

Upstream patch: http://bugs.icu-project.org/trac/changeset/40667

Ref. https://bugs.chromium.org/p/v8/issues/detail?id=4743#c54.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included (upstream)
  • documentation is changed or added (N/A)
  • commit message follows commit guidelines
Affected core subsystem(s)

deps

@mathiasbynens
Copy link
Contributor Author

This is a follow-up to #16876. cc @srl295

@mscdex mscdex added the i18n-api Issues and PRs related to the i18n implementation. label Nov 10, 2017
srl295
srl295 approved these changes Nov 10, 2017
View reviewed changes
Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure… I had not realized that this would be a "code" change only, my concern was mostly over data split.

This way it's overwritten if you rebuild node to download ICU, but that's where things are at present.

refack
refack approved these changes Nov 10, 2017
View reviewed changes
Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp

@srl295 srl295 mentioned this pull request Nov 10, 2017
Closed
fhinkel
fhinkel approved these changes Nov 11, 2017
View reviewed changes
Copy link
Member

@fhinkel fhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubberstamp LGTM

@bricss bricss mentioned this pull request Nov 13, 2017
Merged
mhdawson
mhdawson approved these changes Nov 16, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

@mhdawson
Copy link
Member

CI run: https://ci.nodejs.org/job/node-test-pull-request/11487/

@addaleax
Copy link
Member

Landed in 42bdb66

@addaleax addaleax closed this Nov 18, 2017
addaleax pushed a commit that referenced this pull request Nov 18, 2017
@mathiasbynens @addaleax
deps: cherry-pick upstream ICU fix
42bdb66 
ICU 60.1 has a bug resulting in incorrect Script_Extensions data
for 5 characters.
http://bugs.icu-project.org/trac/ticket/13462

Upstream patch:
http://bugs.icu-project.org/trac/changeset/40667

Refs: https://bugs.chromium.org/p/v8/issues/detail?id=4743#c54
PR-URL: #16931
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@ilovezfs ilovezfs mentioned this pull request Dec 5, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@mathiasbynens @MylesBorins
deps: cherry-pick upstream ICU fix
24bb99a 
ICU 60.1 has a bug resulting in incorrect Script_Extensions data
for 5 characters.
http://bugs.icu-project.org/trac/ticket/13462

Upstream patch:
http://bugs.icu-project.org/trac/changeset/40667

Refs: https://bugs.chromium.org/p/v8/issues/detail?id=4743#c54
PR-URL: #16931
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
@srl295
Copy link
Member

srl295 commented Dec 14, 2017

FWIW this upstream fix landed in ICU 60.2. PR coming soon…

@srl295 srl295 mentioned this pull request Dec 14, 2017
Closed
2 tasks
@MylesBorins MylesBorins added baking-for-lts PRs that need to wait before landing in a LTS release. lts-watch-v6.x labels Dec 19, 2017
srl295 added a commit that referenced this pull request Jan 18, 2018
@srl295
deps: ICU 60.2 bump
e42708c 
- Update to Maintainance ICU 60.2
- CLDR 32.0.1
- http://site.icu-project.org/download/60#TOC-ICU-60.2-bug-fixes
- Subsumes #16931

PR-URL: #17687
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
srl295 added a commit to srl295/node that referenced this pull request Jan 18, 2018
@srl295
deps: ICU 60.2 bump
c0aee51 
- Update to Maintainance ICU 60.2
- CLDR 32.0.1
- http://site.icu-project.org/download/60#TOC-ICU-60.2-bug-fixes
- Subsumes nodejs#16931

PR-URL: nodejs#17687
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 20, 2018
@srl295 @MylesBorins
deps: ICU 60.2 bump
9e7f863 
- Update to Maintainance ICU 60.2
- CLDR 32.0.1
- http://site.icu-project.org/download/60#TOC-ICU-60.2-bug-fixes
- Subsumes #16931

PR-URL: #17687
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@srl295 @MayaLekova
deps: ICU 60.2 bump
c070fbc 
- Update to Maintainance ICU 60.2
- CLDR 32.0.1
- http://site.icu-project.org/download/60#TOC-ICU-60.2-bug-fixes
- Subsumes nodejs#16931

PR-URL: nodejs#17687
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@tniessen tniessen removed the baking-for-lts PRs that need to wait before landing in a LTS release. label Jan 21, 2020
This was referenced Mar 9, 2020
Open
Open
@snyk-bot snyk-bot mentioned this pull request Jul 15, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

@fhinkel fhinkel fhinkel approved these changes

@jasnell jasnell jasnell approved these changes

@srl295 srl295 srl295 approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
i18n-api Issues and PRs related to the i18n implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.