Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: ICU 60.1 bump #16876

Closed
wants to merge 0 commits into from
Closed

deps: ICU 60.1 bump #16876

wants to merge 0 commits into from

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Nov 8, 2017

  • update to final ICU 60.1
  • Somehow took me six days since icu4c 60.1 was released

From http://site.icu-project.org/download/60

ICU 60 provides full support for the recent Unicode 10.0 release with many new characters and many property improvements. Locale data is updated to CLDR 32 which adds several languages and many data improvements. A new, more user-friendly number formatting API has been added.

Unicode 10.0: 8,518 new characters, including four new scripts, 7,494 new Han characters, and 56 new emoji characters.
Properties newly supported in ICU: Emoji_Component, Regional_Indicator, Prepended_Concatenation_Mark
CLDR 32:
Data for several (mostly Asian) new languages, date formatting patterns using colloquial day period formats ("h:mm B" → “1:30 in the afternoon”), and many other data improvements.
See the CLDR download page for other CLDR features and migration issues in CLDR 32.
… Smaller data files for BreakIterator
ICU now handles ill-formed UTF-8 byte sequences as specified in the W3C Encoding Standard.

Fixes: #15540

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

deps

@srl295 srl295 added the i18n-api Issues and PRs related to the i18n implementation. label Nov 8, 2017
@srl295 srl295 self-assigned this Nov 8, 2017
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. labels Nov 8, 2017
@srl295 srl295 added the wip Issues and PRs that are still a work in progress. label Nov 8, 2017
@srl295
Copy link
Member Author

srl295 commented Nov 8, 2017

whitespace changes… i will rebuild this from
f5497e5 and remove whitespace changes.

@srl295
Copy link
Member Author

srl295 commented Nov 8, 2017

As promised, this fixes #15261 / #15263

@srl295
Copy link
Member Author

srl295 commented Nov 8, 2017

@srl295 srl295 removed the wip Issues and PRs that are still a work in progress. label Nov 8, 2017
@srl295
Copy link
Member Author

srl295 commented Nov 8, 2017

re-running tests

  • need to post 60.x icu4c-data so full-icu works (but not before this lands)

@srl295
Copy link
Member Author

srl295 commented Nov 8, 2017

Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@Trott
Copy link
Member

Trott commented Nov 8, 2017

Re-running Raspberry Pi: https://ci.nodejs.org/job/node-test-binary-arm/11626/

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

@srl295
Copy link
Member Author

srl295 commented Nov 8, 2017

@jasnell not so fast, I was able to see this as a change.

ICU now handles ill-formed UTF-8 byte sequences as specified in the W3C Encoding Standard. (#13311)

I was able to express this change in Node as follows. Basically, ICU previously treated a sequence such as \xF0 \x80 as a single erroneous utf-8 sequence, yielding a single U+FFFD (�)

Now, following the w3c standard, ICU 60.1 treats each byte of the input as bad utf-8, yielding U+FFFD U+FFFD (��).

I don't know which other interfaces to test here, and I know that v8 has its own utf-8 encoders. So ICU's utf-8 may not be used in all parts.

Node with ICU 59.1 (v8.5.0)

require('buffer').transcode(Buffer.from([0xF0, 0x80, 0x80]), 'utf-8', 'utf-8') gives the same results as below.

$ node -e "console.dir(process.binding('icu').transcode(Buffer.from([0xf0,0x80]), 'utf-8', 'utf-8'))"
Buffer [ 239, 191, 189 ]

Node with ICU 60.1

require('buffer').transcode(Buffer.from([0xF0, 0x80, 0x80]), 'utf-8', 'utf-8') gives the same results as below.

$ ./node -e "console.dir(process.binding('icu').transcode(Buffer.from([0xf0,0x80]), 'utf-8', 'utf-8'))"
Buffer [ 239, 191, 189, 239, 191, 189 ]

So…

Will this cause any problems?

Buffer.from([0xF0, 0x80, 0x80], 'utf-8').toString().length === 1 with and without this change, for example.

@jasnell
Copy link
Member

jasnell commented Nov 8, 2017

Ahh... That's a fun one. Ok, will go through in more detail then to verify.

@srl295
Copy link
Member Author

srl295 commented Nov 8, 2017

@jasnell actually, given that the utf-8 change was in response to the W3C standard, this PR might really be a bug fix we didn't know we needed.

@mathiasbynens
Copy link
Contributor

It’s a WHATWG standard which the W3C copies. Please link to https://encoding.spec.whatwg.org/ instead.

@srl295
Copy link
Member Author

srl295 commented Nov 8, 2017

@mathiasbynens well, you just did… specifically, https://encoding.spec.whatwg.org/#utf-8-decoder

@srl295
Copy link
Member Author

srl295 commented Nov 9, 2017

Also, irregardless of whether ICU is there or not,

new (require('util').TextDecoder)('utf-8')
 .decode(Buffer.from([0xF0, 0x80, 0x80])).length === 1 // U+FFFD

…and that API claims to be WHATWG compatible (comparable to the W3C link above), but it isn't (per my understanding of the utf-8 issue)- it's compatible with old-ICU. I assume Buffer.from(…) is using v8's non-ICU conversion which is also compatibile with old-ICU.

So I think the way forward here should be:

@jungshik
Copy link

jungshik commented Nov 9, 2017

I assume Buffer.from(…) is using v8's non-ICU conversion which is also compatibile with old-ICU.

Buffer.from([....]) cannot have anything to do with this. Isn't it just creating UInt8Array to pass to TextDecoder('utf-8').decode() ?

kisg pushed a commit to paul99/v8mips that referenced this pull request Nov 9, 2017
This patch explicitly includes unicode/uvernum.h in the regular
expression parser.

It should be removed once we no longer need to check
`U_ICU_VERSION_MAJOR_NUM` during preprocessing, i.e. once Node.js
updates their ICU. This is an ongoing effort:
nodejs/node#16876

BUG=v8:4743

Change-Id: I3cd9447b481249a9035d9fb00745057da8809c58
Reviewed-on: https://chromium-review.googlesource.com/758407
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49253}
kisg pushed a commit to paul99/v8mips that referenced this pull request Nov 9, 2017
This reverts commit 0db90bc.

Reason for revert: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20noi18n%20-%20debug/builds/17335

You need to also check whether i18n is on, e.g. #ifdef V8_INTL_SUPPORT.

Original change's description:
> [regexp] Include unicode/uvernum.h in parser
> 
> This patch explicitly includes unicode/uvernum.h in the regular
> expression parser.
> 
> It should be removed once we no longer need to check
> `U_ICU_VERSION_MAJOR_NUM` during preprocessing, i.e. once Node.js
> updates their ICU. This is an ongoing effort:
> nodejs/node#16876
> 
> BUG=v8:4743
> 
> Change-Id: I3cd9447b481249a9035d9fb00745057da8809c58
> Reviewed-on: https://chromium-review.googlesource.com/758407
> Reviewed-by: Jakob Gruber <jgruber@chromium.org>
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Mathias Bynens <mathias@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#49253}

TBR=yangguo@chromium.org,jshin@chromium.org,jgruber@chromium.org,mathias@chromium.org

Change-Id: I58d6b7a49b707c97153b8b0aec141248f5c669e1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:4743
Reviewed-on: https://chromium-review.googlesource.com/759777
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49255}
kisg pushed a commit to paul99/v8mips that referenced this pull request Nov 9, 2017
This is a reland of 0db90bc
Original change's description:
> [regexp] Include unicode/uvernum.h in parser
>
> This patch explicitly includes unicode/uvernum.h in the regular
> expression parser.
>
> It should be removed once we no longer need to check
> `U_ICU_VERSION_MAJOR_NUM` during preprocessing, i.e. once Node.js
> updates their ICU. This is an ongoing effort:
> nodejs/node#16876
>
> BUG=v8:4743
>
> Change-Id: I3cd9447b481249a9035d9fb00745057da8809c58
> Reviewed-on: https://chromium-review.googlesource.com/758407
> Reviewed-by: Jakob Gruber <jgruber@chromium.org>
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Mathias Bynens <mathias@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#49253}

Bug: v8:4743
Change-Id: Id3f375f27fb5eaa4129884f99095d16763bd6e86
Reviewed-on: https://chromium-review.googlesource.com/758861
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49260}
@mathiasbynens
Copy link
Contributor

Please consider cherry-picking the fix for https://ssl.icu-project.org/trac/ticket/13462 on top of this.

@srl295
Copy link
Member Author

srl295 commented Nov 9, 2017

@jungshik

Buffer.from([....]) cannot have anything to do with this. Isn't it just creating UInt8Array to pass to TextDecoder('utf-8').decode() ?

No, not at all. TextDecoder is new to the table here. Buffer.from ends up calling v8's string code.

@mathiasbynens

Please consider cherry-picking the fix for https://ssl.icu-project.org/trac/ticket/13462 on top of this.

I'd rather not…  Script Extensions… this includes an updated data file. It should be an ICU maint release if it's critical. This would otherwise make the ICU integration unstable: rebuilding with configure or full data would give inconsistent results.

@srl295
Copy link
Member Author

srl295 commented Nov 10, 2017

OK going to land this for now, please open other issues for followup if needed.

srl295 added a commit that referenced this pull request Nov 10, 2017
- Update to released ICU 60.1, including:
  - CLDR 32 (many new languages and data improvements)
  - Unicode 10 (8,518 new characters, including four new scripts,
  7,494 new Han characters, and 56 new emoji characters)
  - UTF-8 malformed bytes now handled according to W3C/WHATWG spec

Fixes: #15540
PR-URL: #16876
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@TimothyGu
Copy link
Member

To confirm, this PR will go into v9.x right? How about v8.x?

evanlucas pushed a commit that referenced this pull request Nov 13, 2017
- Update to released ICU 60.1, including:
  - CLDR 32 (many new languages and data improvements)
  - Unicode 10 (8,518 new characters, including four new scripts,
  7,494 new Han characters, and 56 new emoji characters)
  - UTF-8 malformed bytes now handled according to W3C/WHATWG spec

Fixes: #15540
PR-URL: #16876
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@evanlucas evanlucas mentioned this pull request Nov 13, 2017
@MylesBorins
Copy link
Contributor

I'd like to see this live in a release a tiny bit longer before making it to LTS

It lands cleanly on 8.x, but will require a backport for 6.x

@gibfahn
Copy link
Member

gibfahn commented Dec 13, 2017

Landed this on 8.x.

@srl295 could you raise a backport for 6.x?

gibfahn pushed a commit that referenced this pull request Dec 13, 2017
- Update to released ICU 60.1, including:
  - CLDR 32 (many new languages and data improvements)
  - Unicode 10 (8,518 new characters, including four new scripts,
  7,494 new Han characters, and 56 new emoji characters)
  - UTF-8 malformed bytes now handled according to W3C/WHATWG spec

Fixes: #15540
PR-URL: #16876
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@MylesBorins MylesBorins added the semver-minor PRs that contain new features and should be released in the next minor version. label Dec 13, 2017
@MylesBorins
Copy link
Contributor

I'm adding the semver-minor label defensively... is that accurate?

If so @gibfahn will likely need to back this out of 8.x for now

@gibfahn
Copy link
Member

gibfahn commented Dec 13, 2017

If so @gibfahn will likely need to back this out of 8.x for now

Good point, backed out.

@srl295
Copy link
Member Author

srl295 commented Dec 13, 2017

so… 60.2 coming soon.
Edit: #17687

@srl295 srl295 changed the title deps: ICU 60 bump deps: ICU 60.1 bump Dec 14, 2017
@srl295 srl295 mentioned this pull request Dec 14, 2017
2 tasks
@mhdawson
Copy link
Member

@srl295 if we want this on 6.x we need a backport PR this week.

MylesBorins pushed a commit that referenced this pull request Jan 15, 2018
- Update to released ICU 60.1, including:
  - CLDR 32 (many new languages and data improvements)
  - Unicode 10 (8,518 new characters, including four new scripts,
  7,494 new Han characters, and 56 new emoji characters)
  - UTF-8 malformed bytes now handled according to W3C/WHATWG spec

Fixes: #15540
PR-URL: #16876
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@srl295
Copy link
Member Author

srl295 commented Jan 18, 2018

@mhdawson now this should backport #17687

srl295 added a commit to srl295/node that referenced this pull request Jan 18, 2018
- Update to released ICU 60.1, including:
  - CLDR 32 (many new languages and data improvements)
  - Unicode 10 (8,518 new characters, including four new scripts,
  7,494 new Han characters, and 56 new emoji characters)
  - UTF-8 malformed bytes now handled according to W3C/WHATWG spec

Fixes: nodejs#15540
PR-URL: nodejs#16876
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
gibfahn added a commit that referenced this pull request Mar 6, 2018
Notable changes:

* deps:
  * update V8 to 6.2.414.46 (Michaël Zasso) [#16413](#16413)
  * revert ABI breaking changes in V8 6.2 (Anna Henningsen) [#16413](#16413)
  * upgrade libuv to 1.19.1 (cjihrig) [#18260](#18260)
  * re land npm 5.6.0 (Myles Borins) [#18625](#18625)
  * ICU 60 bump (Steven R. Loomis) [#16876](#16876)
* crypto:
  * Support both OpenSSL 1.1.0 and 1.0.2 (David Benjamin) [#16130](#16130)
  * warn on invalid authentication tag length (Tobias Nießen) [#17566](#17566)
* async_hooks:
  * update defaultTriggerAsyncIdScope for perf (Anatoli Papirovski) [#18004](#18004)
  * use typed array stack as fast path (Anna Henningsen) [#17780](#17780)
  * use scope for defaultTriggerAsyncId (Andreas Madsen) [#17273](#17273)
  * separate missing from default context (Andreas Madsen) [#17273](#17273)
  * rename initTriggerId (Andreas Madsen) [#17273](#17273)
  * deprecate undocumented API (Andreas Madsen) [#16972](#16972)
  * add destroy event for gced AsyncResources (Sebastian Mayr) [#16998](#16998)
  * add trace events to async_hooks (Andreas Madsen) [#15538](#15538)
  * set HTTPParser trigger to socket (Andreas Madsen) [#18003](#18003)
  * add provider types for net server (Andreas Madsen) [#17157](#17157)
* n-api:
  * add helper for addons to get the event loop (Anna Henningsen) [#17109](#17109)
* cli:
  * add --stack-trace-limit to NODE_OPTIONS (Anna Henningsen) [#16495](#16495)
* console:
  * add support for console.debug (Benjamin Zaslavsky) [#17033](#17033)
* module:
  * add builtinModules (Jon Moss) [#16386](#16386)
  * replace default paths in require.resolve() (cjihrig) [#17113](#17113)
* src:
  * add helper for addons to get the event loop (Anna Henningsen) [#17109](#17109)
  * add process.ppid (cjihrig) [#16839](#16839)
* http:
  * support generic `Duplex` streams (Anna Henningsen) [#16267](#16267)
  * add rawPacket in err of `clientError` event (XadillaX) [#17672](#17672)
  * better support for IPv6 addresses (Mattias Holmlund) [#14772](#14772)
* net:
  * remove ADDRCONFIG DNS hint on Windows (Bartosz Sosnowski) [#17662](#17662)
* process:
  * fix reading zero-length env vars on win32 (Anna Henningsen) [#18463](#18463)
* tls:
  * unconsume stream on destroy (Anna Henningsen) [#17478](#17478)
* process:
  * improve unhandled rejection message (Madara Uchiha) [#17158](#17158)
* stream:
  * remove usage of *State.highWaterMark (Calvin Metcalf) [#12860](#12860)
* trace_events:
  * add executionAsyncId to init events (Andreas Madsen) [#17196](#17196)

PR-URL: #18336
gibfahn added a commit that referenced this pull request Mar 7, 2018
Notable changes:

* deps:
  * update V8 to 6.2.414.46 (Michaël Zasso) [#16413](#16413)
  * revert ABI breaking changes in V8 6.2 (Anna Henningsen) [#16413](#16413)
  * upgrade libuv to 1.19.1 (cjihrig) [#18260](#18260)
  * re land npm 5.6.0 (Myles Borins) [#18625](#18625)
  * ICU 60 bump (Steven R. Loomis) [#16876](#16876)
* crypto:
  * Support both OpenSSL 1.1.0 and 1.0.2 (David Benjamin) [#16130](#16130)
  * warn on invalid authentication tag length (Tobias Nießen) [#17566](#17566)
* async_hooks:
  * update defaultTriggerAsyncIdScope for perf (Anatoli Papirovski) [#18004](#18004)
  * use typed array stack as fast path (Anna Henningsen) [#17780](#17780)
  * use scope for defaultTriggerAsyncId (Andreas Madsen) [#17273](#17273)
  * separate missing from default context (Andreas Madsen) [#17273](#17273)
  * rename initTriggerId (Andreas Madsen) [#17273](#17273)
  * deprecate undocumented API (Andreas Madsen) [#16972](#16972)
  * add destroy event for gced AsyncResources (Sebastian Mayr) [#16998](#16998)
  * add trace events to async_hooks (Andreas Madsen) [#15538](#15538)
  * set HTTPParser trigger to socket (Andreas Madsen) [#18003](#18003)
  * add provider types for net server (Andreas Madsen) [#17157](#17157)
* n-api:
  * add helper for addons to get the event loop (Anna Henningsen) [#17109](#17109)
* cli:
  * add --stack-trace-limit to NODE_OPTIONS (Anna Henningsen) [#16495](#16495)
* console:
  * add support for console.debug (Benjamin Zaslavsky) [#17033](#17033)
* module:
  * add builtinModules (Jon Moss) [#16386](#16386)
  * replace default paths in require.resolve() (cjihrig) [#17113](#17113)
* src:
  * add helper for addons to get the event loop (Anna Henningsen) [#17109](#17109)
  * add process.ppid (cjihrig) [#16839](#16839)
* http:
  * support generic `Duplex` streams (Anna Henningsen) [#16267](#16267)
  * add rawPacket in err of `clientError` event (XadillaX) [#17672](#17672)
  * better support for IPv6 addresses (Mattias Holmlund) [#14772](#14772)
* net:
  * remove ADDRCONFIG DNS hint on Windows (Bartosz Sosnowski) [#17662](#17662)
* process:
  * fix reading zero-length env vars on win32 (Anna Henningsen) [#18463](#18463)
* tls:
  * unconsume stream on destroy (Anna Henningsen) [#17478](#17478)
* process:
  * improve unhandled rejection message (Madara Uchiha) [#17158](#17158)
* stream:
  * remove usage of *State.highWaterMark (Calvin Metcalf) [#12860](#12860)
* trace_events:
  * add executionAsyncId to init events (Andreas Madsen) [#17196](#17196)

PR-URL: #18336
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
Notable changes:

* deps:
  * update V8 to 6.2.414.46 (Michaël Zasso) [nodejs#16413](nodejs#16413)
  * revert ABI breaking changes in V8 6.2 (Anna Henningsen) [nodejs#16413](nodejs#16413)
  * upgrade libuv to 1.19.1 (cjihrig) [nodejs#18260](nodejs#18260)
  * re land npm 5.6.0 (Myles Borins) [nodejs#18625](nodejs#18625)
  * ICU 60 bump (Steven R. Loomis) [nodejs#16876](nodejs#16876)
* crypto:
  * Support both OpenSSL 1.1.0 and 1.0.2 (David Benjamin) [nodejs#16130](nodejs#16130)
  * warn on invalid authentication tag length (Tobias Nießen) [nodejs#17566](nodejs#17566)
* async_hooks:
  * update defaultTriggerAsyncIdScope for perf (Anatoli Papirovski) [nodejs#18004](nodejs#18004)
  * use typed array stack as fast path (Anna Henningsen) [nodejs#17780](nodejs#17780)
  * use scope for defaultTriggerAsyncId (Andreas Madsen) [nodejs#17273](nodejs#17273)
  * separate missing from default context (Andreas Madsen) [nodejs#17273](nodejs#17273)
  * rename initTriggerId (Andreas Madsen) [nodejs#17273](nodejs#17273)
  * deprecate undocumented API (Andreas Madsen) [nodejs#16972](nodejs#16972)
  * add destroy event for gced AsyncResources (Sebastian Mayr) [nodejs#16998](nodejs#16998)
  * add trace events to async_hooks (Andreas Madsen) [nodejs#15538](nodejs#15538)
  * set HTTPParser trigger to socket (Andreas Madsen) [nodejs#18003](nodejs#18003)
  * add provider types for net server (Andreas Madsen) [nodejs#17157](nodejs#17157)
* n-api:
  * add helper for addons to get the event loop (Anna Henningsen) [nodejs#17109](nodejs#17109)
* cli:
  * add --stack-trace-limit to NODE_OPTIONS (Anna Henningsen) [nodejs#16495](nodejs#16495)
* console:
  * add support for console.debug (Benjamin Zaslavsky) [nodejs#17033](nodejs#17033)
* module:
  * add builtinModules (Jon Moss) [nodejs#16386](nodejs#16386)
  * replace default paths in require.resolve() (cjihrig) [nodejs#17113](nodejs#17113)
* src:
  * add helper for addons to get the event loop (Anna Henningsen) [nodejs#17109](nodejs#17109)
  * add process.ppid (cjihrig) [nodejs#16839](nodejs#16839)
* http:
  * support generic `Duplex` streams (Anna Henningsen) [nodejs#16267](nodejs#16267)
  * add rawPacket in err of `clientError` event (XadillaX) [nodejs#17672](nodejs#17672)
  * better support for IPv6 addresses (Mattias Holmlund) [nodejs#14772](nodejs#14772)
* net:
  * remove ADDRCONFIG DNS hint on Windows (Bartosz Sosnowski) [nodejs#17662](nodejs#17662)
* process:
  * fix reading zero-length env vars on win32 (Anna Henningsen) [nodejs#18463](nodejs#18463)
* tls:
  * unconsume stream on destroy (Anna Henningsen) [nodejs#17478](nodejs#17478)
* process:
  * improve unhandled rejection message (Madara Uchiha) [nodejs#17158](nodejs#17158)
* stream:
  * remove usage of *State.highWaterMark (Calvin Metcalf) [nodejs#12860](nodejs#12860)
* trace_events:
  * add executionAsyncId to init events (Andreas Madsen) [nodejs#17196](nodejs#17196)

PR-URL: nodejs#18336
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. i18n-api Issues and PRs related to the i18n implementation. meta Issues and PRs related to the general management of the project. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants