Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add Malte-Thorben Bruns to .mailmap #1118

Merged
merged 1 commit into from
Mar 10, 2015

Conversation

bnoordhuis
Copy link
Member

@cjihrig
Copy link
Contributor

cjihrig commented Mar 10, 2015

LGTM

PR-URL: nodejs#1118
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@bnoordhuis bnoordhuis closed this Mar 10, 2015
@bnoordhuis bnoordhuis deleted the update-mailmap branch March 10, 2015 15:38
@bnoordhuis bnoordhuis merged commit 60dac07 into nodejs:v1.x Mar 10, 2015
@Fishrock123
Copy link
Contributor

When are we supposed to do this normally? I don't really get this whole thing.

@Fishrock123
Copy link
Contributor

Wait, in 80e14d7 is his email wrong? Oops.

@rvagg
Copy link
Member

rvagg commented Mar 10, 2015

this is the same person right? shouldn't it have been:

Malte-Thorben Bruns <skenqbx@gmail.com> <skenqbx@googlemail.com>

@Fishrock123 man git-shortlog and look at the MAPPING AUTHORS section

@bnoordhuis
Copy link
Member Author

Oops, yes. I believe both are okay, though.

@skenqbx
Copy link
Contributor

skenqbx commented Mar 10, 2015

Yes, both work. In the beginnings of gmail in Germany only googlemail.com adresses were available.

@rvagg rvagg mentioned this pull request Mar 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants