Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release proposal: v1.6.0 #1157

Closed
rvagg opened this issue Mar 14, 2015 · 46 comments
Closed

Release proposal: v1.6.0 #1157

rvagg opened this issue Mar 14, 2015 · 46 comments
Labels
meta Issues and PRs related to the general management of the project.

Comments

@rvagg
Copy link
Member

rvagg commented Mar 14, 2015

We're starting to need a new release but we're in an awkward position of not having a good story around a semver-minor bump and there's a few issues & PRs in flux that would be good to get resolved before a release.

Note in the commit list below, the commit from #881 was reverted so no longer applies, but its resolution may be at hand so it can come back in. This would help with a 1.6.0 justification.

Also for those interested in semver arguments, please head over to #1116 and see what you think about it being semver-minor or semver-patch. It's the only thing in here that's warranting the bump to 1.6. If it wasn't for this addition then I'd have just pushed for a quick 1.5.2 and be done with this batch of commits.

So, I'm proposing a holding pattern for this release for up to 3 days to see if we can get some meat in here. Some issues worth monitoring are:

@Fishrock123
Copy link
Contributor

ahhh ya beat me to it, I decided to hold off until tomorrow haha

👍

@ghost
Copy link

ghost commented Mar 14, 2015

LGTM However, it may be better to wait until new release and backport.

@piscisaureus
Copy link
Contributor

[7bde3f1] - (SEMVER-MINOR) src: add -r/--require flags for preloading modules (Ali Ijaz Sheikh)

This patch has been reverted for now I thought?

@rvagg
Copy link
Member Author

rvagg commented Mar 14, 2015

yep

[056ed4b] - src: revert -r/--require flags (Chris Dickinson) #1150

@mikeal
Copy link
Contributor

mikeal commented Mar 14, 2015

This should probably be a semver-major change if accepted (I don't think it will be, that issue seems to be going another way).

@brendanashworth
Copy link
Contributor

A good reason for semver-minor could be #1156

@bnoordhuis
Copy link
Member

Another one: #1162

@cjihrig
Copy link
Contributor

cjihrig commented Mar 16, 2015

Another semver minor: #1163. Specifically, 095ae0d.

@jameshartig
Copy link
Contributor

Since 095ae0d is my commit, I'm not sure if I should chime in or not but its just making socket*() return the ip/port used even after the socket is closed. Before that commit, if the socket was closed, socket*() methods would return null.

@bnoordhuis
Copy link
Member

@fastest963 I suggested semver-minor because it can break code that uses e.g. socket.remotePort === undefinedas an indicator of whether the socket is connected.

@jameshartig
Copy link
Contributor

@bnoordhuis thanks for the clarification. Makes sense.

@rvagg
Copy link
Member Author

rvagg commented Mar 17, 2015

will try and get this out tomorrow, then I guess we'll have 1.6.1 to do in a couple of days after that thanks to openssl.

@shigeki
Copy link
Contributor

shigeki commented Mar 18, 2015

@rvagg Your CI of 317 was deleted and my job had an error as https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/318/console . Is there something wrong on CI?

@jbergstroem
Copy link
Member

@shigeki yeah, so it seems :-/

@rvagg
Copy link
Member Author

rvagg commented Mar 18, 2015

Jenkins and plugin upgrade gone wrong, I've been through most of the hosts now and sorted everything out and we are back on track again

CI: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/321/

RC: https://jenkins-iojs.nodesource.com/job/iojs+release+nightly/109/ -> https://iojs.org/download/nightly/v1.5.2-nightly201503182b63bcd247/

We've lost the ARMv8 host for now, working with Linaro to get another one back for that.

@shigeki
Copy link
Contributor

shigeki commented Mar 18, 2015

@rvagg Thanks for your quick fix. Wait and see if your job is completed.

@shigeki
Copy link
Contributor

shigeki commented Mar 18, 2015

configure on FreeBSD in CI were failed because of no envs of CC and CXX which are required by 8b2363d . CC=cc and CXX=c++ or both of clang are needed.

@rvagg
Copy link
Member Author

rvagg commented Mar 18, 2015

I wouldn't mind seeing #881 come back in before this release, it seems to be ready but I'm not brave enough to merge it given the Windows uncertainty

@jbergstroem
Copy link
Member

@shigeki good catch. I've corrected it in Jenkins.

@rvagg
Copy link
Member Author

rvagg commented Mar 18, 2015

as per TC discussion today, we're going to hold this release until the OpenSSL patch, WIP in #1186. I should be able to come up with the initial ChangeLog header today and have everything ready, then either myself or @chrisdickinson will make the release when that fix comes out depending on whether I'm around or not (AEST).

@rvagg
Copy link
Member Author

rvagg commented Mar 19, 2015

2015-03-19, Version 1.6.0, @rvagg

Notable changes

  • node: a new -r or --require command-line option can be used to pre-load modules at start-up (Ali Ijaz Sheikh) #881.
  • querystring: parse() and stringify() are now faster (Brian White) #847.
  • http: the http.ClientRequest#flush() method has been deprecated and replaced with http.ClientRequest#flushHeaders() to match the same change now in Node.js v0.12 as per joyent/node#9048 (Yosuke Furukawa) #1156.
  • net: allow server.listen() to accept a String option for port, e.g. { port: "1234" }, to match the same option being accepted in net.connect() as of joyent/node#9268 (Ben Noordhuis) #1116.
  • tls: further work on the reported memory leak although there appears to be a minor leak remaining for the use-case in question, track progress at #1075.
  • v8: backport a fix for an integer overflow when --max_old_space_size values above 4096 are used (Ben Noordhuis) #1166.
  • platforms: the io.js CI system now reports passes on FreeBSD and SmartOS (Solaris).
  • npm: upgrade npm to 2.7.1. See npm CHANGELOG.md for details. Summary:
    • 6823807 #7121 npm install --save for Git dependencies saves the URL passed in, instead of the temporary directory used to clone the remote repo. Fixes using Git dependencies when shrinkwwapping. In the process, rewrote the Git dependency caching code. Again. No more single-letter variable names, and a much clearer workflow. (@othiym23)
    • abdd040 read-package-json@1.3.2: Provide more helpful error messages when JSON parse errors are encountered by using a more forgiving JSON parser than JSON.parse. (@smikes)
    • c56cfcd #7525 npm dedupe handles scoped packages. (@KidkArolis)
    • 4ef1412 #7075 If you try to tag a release as a valid semver range, npm publish and npm tag will error early instead of proceeding. (@smikes)

Known issues

  • Possible remaining TLS-related memory leak(s), details at #1075.
  • Surrogate pair in REPL can freeze terminal #690
  • Not possible to build io.js as a static library #686
  • process.send() is not synchronous as the docs suggest, a regression introduced in 1.0.2, see #760 and fix in #774
  • Calling dns.setServers() while a DNS query is in progress can cause the process to crash on a failed assertion #894

Commits

@rvagg
Copy link
Member Author

rvagg commented Mar 19, 2015

RC, minus OpenSSL fix, running @ https://jenkins-iojs.nodesource.com/job/iojs+release+nightly/110/, coming out at https://iojs.org/download/nightly/v1.5.2-nightly201503191514b82355/

@iojs/collaborators could we have a soft freeze until we get this out please. Hold off on non-trivial changes to core code. Also testers of the RC would be appreciated if you're in a position to do so.

@mgol
Copy link
Contributor

mgol commented Mar 19, 2015

@rvagg All my packages pass their tests with the nightly.

@rvagg
Copy link
Member Author

rvagg commented Mar 19, 2015

thanks for testing @mzgol !

@Fishrock123
Copy link
Contributor

upgrade npm to 2.7.1.See

Missing a space after the version :)

@rvagg
Copy link
Member Author

rvagg commented Mar 19, 2015

getting a bit late for me here, will pass the baton to @chrisdickinson to ease this one out the door--unless I'm up again before this thing comes out

@chrisdickinson: the promotion script near the end isn't quite set up right and you'll get errors about not being able to remove doc files but you can safely ignore those; a bug yet to be fixed but it doesn't impact on builds.

@rvagg
Copy link
Member Author

rvagg commented Mar 19, 2015

Feel free to steal all my wording above and put your name on it bte Chris, I don't want you feeling award about appropriating my words.

@chrisdickinson
Copy link
Contributor

Starting up the process now. Merging #1206.

@chrisdickinson
Copy link
Contributor

Merged. Running the tests again just to be sure.

@chrisdickinson
Copy link
Contributor

Tests seem green (well, blue, but you know.) Cutting nightlies now.

@chrisdickinson
Copy link
Contributor

Nightlies are processing, processing, processing.

@chrisdickinson
Copy link
Contributor

Nightlies are out. Tested on Win7 64, OSX 10.10 64, all looks good. Proceeding.

@chrisdickinson
Copy link
Contributor

Release commit is authored. Editing the markdown out is kind of a slog – anyone have a better solution?

@chrisdickinson
Copy link
Contributor

Tagged and pushed to v1.x. Starting release process.

Job is here.

@chrisdickinson
Copy link
Contributor

OSX build has finished. Tested against hapi on v10.10, works.

@chrisdickinson
Copy link
Contributor

Windows 2008 x64 has finished. Tested against hapi on windows 7. Some test failures (looks like it was sniffing for error messages!)

@chrisdickinson
Copy link
Contributor

Looks like our ARM friends have hung. Proceeding to promote others, will circle back on ARM builds later.

@chrisdickinson
Copy link
Contributor

Done. cc @Fishrock123, we should be good to go.

@Fishrock123
Copy link
Contributor

Website updated: nodejs/iojs.org@8a6bb34

@jbergstroem
Copy link
Member

Great job all 🎉

@feross
Copy link
Contributor

feross commented Mar 19, 2015

Looks like we might need a quick 1.6.1 to fix this bug: #1208

@rvagg
Copy link
Member Author

rvagg commented Mar 20, 2015

@chrisdickinson the arm builds for 1.6.0 are ready to promote, would you mind bumping those with tools/release.sh

@chrisdickinson
Copy link
Contributor

@rvagg sorry, I dropped the ball on the arm builds. OK to run this now?

@rvagg
Copy link
Member Author

rvagg commented Mar 20, 2015

@chrisdickinson yep, should be, first time we've had overlap like this so I'm keen to see if it works as planned!

@chrisdickinson
Copy link
Contributor

Seems to have worked!

@mscdex mscdex added the meta Issues and PRs related to the general management of the project. label Mar 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

No branches or pull requests