Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override BUILDING_UV_SHARED, BUILDING_V8_SHARED. #915

Merged
merged 1 commit into from
Jun 16, 2016
Merged

Override BUILDING_UV_SHARED, BUILDING_V8_SHARED. #915

merged 1 commit into from
Jun 16, 2016

Commits on Jun 16, 2016

  1. Override BUILDING_UV_SHARED, BUILDING_V8_SHARED. 

    We were inheriting BUILDING_UV_SHARED and BUILDING_V8_SHARED from
the common.gypi from the node.js source tree.  Override them with
USING_UV_SHARED and USING_V8_SHARED so symbols get tagged with
`__declspec(dllimport)` instead of `__declspec(dllexport)`, which
is the desired attribute when building add-ons.

Fixes: #914
PR-URL: #915
Reviewed-By: Benjamin Byholm <bbyholm@abo.fi>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
    @bnoordhuis
    bnoordhuis committed Jun 16, 2016
    Configuration menu
    Copy the full SHA
    cc778e9 View commit details
    Browse the repository at this point in the history