Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override BUILDING_UV_SHARED, BUILDING_V8_SHARED. #915

Merged
merged 1 commit into from
Jun 16, 2016
Merged

Override BUILDING_UV_SHARED, BUILDING_V8_SHARED. #915

merged 1 commit into from
Jun 16, 2016

Conversation

bnoordhuis
Copy link
Member

We were inheriting BUILDING_UV_SHARED and BUILDING_V8_SHARED from
the common.gypi from the node.js source tree. Override them with
USING_UV_SHARED and USING_V8_SHARED so symbols get tagged with
__declspec(dllimport) instead of __declspec(dllexport), which
is the desired attribute when building add-ons.

Fixes: #914

@rvagg
Copy link
Member

rvagg commented Jun 14, 2016

this one is a bit beyond me, @indutny, @kkoopa?

@kkoopa
Copy link

kkoopa commented Jun 14, 2016

Seems correct

@indutny
Copy link
Member

indutny commented Jun 14, 2016

LGTM

We were inheriting BUILDING_UV_SHARED and BUILDING_V8_SHARED from
the common.gypi from the node.js source tree.  Override them with
USING_UV_SHARED and USING_V8_SHARED so symbols get tagged with
`__declspec(dllimport)` instead of `__declspec(dllexport)`, which
is the desired attribute when building add-ons.

Fixes: #914
PR-URL: #915
Reviewed-By: Benjamin Byholm <bbyholm@abo.fi>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
@bnoordhuis bnoordhuis merged commit cc778e9 into nodejs:master Jun 16, 2016
@bnoordhuis bnoordhuis deleted the bug914 branch June 16, 2016 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants