Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add current members #1

Closed
wants to merge 1 commit into from
Closed

Add current members #1

wants to merge 1 commit into from

Conversation

tjconcept
Copy link

Would it make sense to move everything TSC here to avoid pollution of the node repository?

See nodejs/node#2925

@Fishrock123
Copy link
Contributor

@tjconcept oops, looks like this was a while ago. :S

Those meeting don't belong here imo, they are mostly technical.

If you'd be willing to change this to just add the members here: https://github.com/nodejs/TSC#tsc-members I'll gladly take a look at the PR. :)

@tjconcept
Copy link
Author

Sure.

@tjconcept tjconcept changed the title Proposal: add meetings and current members Proposal: add current members Jan 13, 2016
@tjconcept tjconcept changed the title Proposal: add current members Add current members Jan 13, 2016
@tjconcept
Copy link
Author

Looks like you've semi-adopted a new commit message style since then - do you want me to prefix it with "doc:"?

@Fishrock123
Copy link
Contributor

@tjconcept That's git-style spill-over from nodejs/node. We wouldn't mind it, but you don't have to here.

@tjconcept
Copy link
Author

I assumed that. I will leave it then.

@Fishrock123
Copy link
Contributor

@tjconcept Ah sorry I didn't get to this sooner, we merged another thing with a description of TSC members, so this has conflicts? If you'd mind to rebase I can merge it asap. :)

@tjconcept
Copy link
Author

Yep, you want them below or above the new text?

@Fishrock123
Copy link
Contributor

Below is fine. :)

@@ -20,6 +20,20 @@ minutiae as the TSC delegates most of its responsibilities to other projects and
Every Top Level Project not currently incubating can appoint someone to the TSC who they elect
at their own discretion.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, maybe it would be best to have an ### heading here saying something like "List of Current TSC Members"?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's the problem with having it below. It just seems a bit redundant to add another header?

If anything, I think "Current members" makes the most sense as the previous header already states "TSC".

@williamkapke
Copy link
Contributor

@tjconcept @Fishrock123 More thoughts/changes on this? I'd like to see it happen.

@rvagg
Copy link
Member

rvagg commented Jun 14, 2016

thanks @tjconcept, went with @williamkapke ✨'s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants