Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Mask fieldmap before fitting spline field [backport gh-396] #398

Merged
merged 1 commit into from
Nov 9, 2023
Merged

FIX: Mask fieldmap before fitting spline field [backport gh-396] #398

merged 1 commit into from
Nov 9, 2023

Conversation

effigies
Copy link
Member

@effigies effigies commented Oct 4, 2023 •
edited
Loading

Straightforward backport. Would still be good to get a test. To anybody willing:

$ git clone https://github.com/effigies/sdcflows.git
$ git -C sdcflows checkout bp/2.5.x/396
$ pipx run "fmriprep-docker==23.1.4" [usual arguments] --patch sdcflows=$PWD/sdcflows/sdcflows

Backport of #396.

@effigies effigies mentioned this pull request Oct 4, 2023
Closed
@effigies
Copy link
Member Author

effigies commented Oct 25, 2023 •
edited
Loading

@oesteban WDYT about this backport? Are you comfortable doing this in a bug-fix release? I'm considering dropping it in and making a final bug-fix release of 23.1.x so the fix can be available for people before 23.2 is finalized

@effigies effigies merged commit c592658 into nipreps:maint/2.5.x Nov 9, 2023
16 checks passed
@effigies effigies deleted the bp/2.5.x/396 branch November 9, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@effigies