FIX: Mask fieldmap before fitting spline field #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #396 +/- ##
=======================================
Coverage 80.56% 80.57%
=======================================
Files 26 26
Lines 2290 2291 +1
Branches 287 287
=======================================
+ Hits 1845 1846 +1
Misses 401 401
Partials 44 44
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Previously, we fit a spline field to the within-mask portion of a fieldmap, which could lead to large peaks outside the mask. Applying the mask to the reconstructed field can produce discontinuities in resampling. Instead of attempting to attenuate the peaks outside the mask in a smooth way, we set the fit values outside the mask to zero, and let the spline fit find a smooth field. In practice, we've found that even fields with large peaks on the edge of the mask are well fit by this method.
effigies
force-pushed
the
fix/mask-bs-filter
branch
from
36d53a9
to
d518851
Compare
|
As discussed, going ahead with this option. This will be in the next unstable release of fmriprep. |
effigies
added a commit
to effigies/sdcflows
that referenced
this pull request
Oct 4, 2023
effigies
added a commit
to effigies/sdcflows
that referenced
this pull request
Oct 4, 2023
effigies
added a commit
that referenced
this pull request
Nov 9, 2023
FIX: Mask fieldmap before fitting spline field [backport gh-396]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we fit a spline field to the within-mask portion of a fieldmap, which could lead to large peaks outside the mask. Applying the mask to the reconstructed field can produce discontinuities in resampling. Instead of attempting to attenuate the peaks outside the mask in a smooth way, we set the fit values outside the mask to zero, and let the spline fit find a smooth field.
Replaces #395.
Addresses nipreps/fmriprep#3013.
Before
After