-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove shallowCopy for ARC/ORC #20070
Conversation
Two important packages are affected. It seems to be easy to fix them. |
Prs prepared for important packages: |
My two prs were merged, just needing to wait for their new release. |
I just did an arraymancer PR to also run the CI under ORC. I decided to run it in release mode, so it doesn't take up too much CI time. Locally I only ran the code in debug mode. Turns out, what is essentially this issue (I think): is still alive and kicking and breaks the ORC (and ARC, checked now locally) release tests of arraymancer: https://github.com/mratsim/Arraymancer/runs/7499159222?check_suite_focus=true#step:18:4781 |
Yeah, we don't have ORC CI for arraymancer. The actual packages affected by this PR is numericalnim. |
Yeah, the issue blocks defaults to Orc |
I see. Is it worth it to push a new arraymancer tag before that issue is fixed then? Personally I'd rather wait until it's fixed, make sure the CI passes & then push a new tag. |
This is a seperate critical issue for ARC/ORC. I hope this PR can be merged as soon as possible(this week is better). |
Fair enough, just tagged a new version. |
It seems to be ready since |
Thanks for your hard work on this PR! Hint: mm: orc; threads: on; opt: speed; options: -d:release |
Wouldn't it have been better to just make it pop a warning in A/ORC? (Or ideally make it work under ARC/ORC, like an alias to move, but that may not be possible) |
See also discussions from #20025 |
* remove shallowCopy for ARC/ORC * use move * fix * more fixes * typo * Update lib/system.nim * follow * add nodestroy * move * copy string * add a changelog entry Co-authored-by: xflywind <43030857+xflywind@users.noreply.github.com> Co-authored-by: Andreas Rumpf <rumpf_a@web.de>
* remove shallowCopy for ARC/ORC * use move * fix * more fixes * typo * Update lib/system.nim * follow * add nodestroy * move * copy string * add a changelog entry Co-authored-by: xflywind <43030857+xflywind@users.noreply.github.com> Co-authored-by: Andreas Rumpf <rumpf_a@web.de>
todo: