-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
defaults to ORC #19972
defaults to ORC #19972
Conversation
Maybe the default GC for the compiler should be changed in https://github.com/nim-lang/Nim/blob/devel/compiler/nim.cfg instead? |
#19403 should fix the failure of Nim doc CI. |
Here is the draft of "Migration to ORC", I'm adding add issues and solutions of ORC => #20017 |
… pr_default_orc
It is ready for review. So that we can ensure new merged prs are compatible with ORC. |
Thanks for your hard work on this PR! Hint: mm: orc; threads: on; opt: speed; options: -d:release |
I will add a changelog and modify corresponding documentation soon. |
Many bullet points (such as |
The Nim repo always uses squash merge, it is fine not to rebase. |
My point is about cleaning up the commit message before pushing. Several folks have mentioned this. Force push in a pull request may help (github's review system used to throw away review comments but it gets improved in recent years.) There are a lot of arguments on the Internet, e.g. https://sourceware.org/gdb/wiki/ContributionChecklist#Detailed_Explanation_of_the_Patch |
* defaults to Orc * bootstrap using refc * use gc * init orc defines * unregister orc * fix gc * fix commands * add prepareMutation for orc * enable deepcopy for orc * prepareMutation * more fixes * some cases * bug nim-lang#20081 * partial fixes * partial fixes * fixes command line * more fixes * build Nim with refc * use gc * more fixes * rstore * orc doesn't support threadpool * more shallowCopy * more fixes * fixes unsafeNew * workarounds * small * more fixes * fixes some megatest * tcodegenbugs1 refc * fxies megatest * build nimble with refc * workaround tensordsl tests * replace shallowCopy with move * fixes action * workaround * add todo * fixes important packages * unpublic unregisterArcOrc * fixes cpp * enable windows Co-authored-by: xflywind <43030857+xflywind@users.noreply.github.com>
No description provided.