Prod Release 20240910 #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On archive pages the "Panel Guidance" tag should no longer appear as a banner over cards. See: https://dxw.zendesk.com/agent/tickets/20084
Do not display Panel Guidance tags on cards
This commit modifies the logic to use the correct property of the object to allow the test to function as expected To Test: - locally have a guidance listing page and an ig_guidance page of the type Panel Guidance and an ig_guidance page of another type (eg external) - load the guidance listing page - confirm that there is no label 'Panel Guidance' in the panel guidance page's card - confirm that the expected label is displayed on the card for the page that has a different type
Use the correct property in the test for the logic to function
snim2
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release changes the display of Internal guidance cards in the guidance listing archive, so that the label on the card is only displayed if the child page is not a Panel Guidance type page