Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not display Panel Guidance tags on cards #804

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Conversation

snim2
Copy link
Collaborator

@snim2 snim2 commented Sep 2, 2024

On archive pages the "Panel Guidance" tag should no longer appear as a banner over cards.

See: https://dxw.zendesk.com/agent/tickets/20084

Testing

You can validate some of this PR by going to a page like:

https://transform.england.nhs.uk/information-governance/guidance/

and using dev tools to delete an HTML element like <span class="nhsai_resource__category">...</span>

You can also use git grep nhsai_resource__category to check where the element we're deleting appears in the site source.

On staging we can test this page: https://web.staging.nhsx-website.dalmatian.dxw.net/information-governance/guidance/

On archive pages the "Panel Guidance" tag should no
longer appear as a banner over cards.

See: https://dxw.zendesk.com/agent/tickets/20084
@snim2 snim2 marked this pull request as ready for review September 9, 2024 15:31
Copy link
Collaborator

@jkeasley jkeasley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snim2 snim2 merged commit 59ce04f into dev Sep 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants