Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove request password button when verif disabled #4769

Merged
merged 1 commit into from
Dec 16, 2020

Conversation

PVince81
Copy link
Member

Whenever the video verification has not been set for a share, do not
display the button "Request password" in the public link page.

Somehow it looks like there was no test anywhere before, maybe it was always missing ?

Fixes #4523

  • TEST: no button when video verif was not ticked
  • TEST: button appears when video verif is ticked
  • TEST: verified that the talk sidebar still appears for link file share when video verif is off

Whenever the video verification has not been set for a share, do not
display the button "Request password" in the public link page.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@PVince81 PVince81 merged commit 8f06b37 into master Dec 16, 2020
@PVince81 PVince81 deleted the bugfix/4523/fix-video-verif-button-disabled branch December 16, 2020 10:31
@nickvergessen nickvergessen added this to the 11.0.0-alpha.1 milestone Dec 18, 2020
@nickvergessen
Copy link
Member

/backport to stable20.1

@nickvergessen
Copy link
Member

/backport to stable20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page asking for password of shared file contains "Request password" button
2 participants