Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page asking for password of shared file contains "Request password" button #4523

Closed
mknet opened this issue Nov 3, 2020 · 6 comments · Fixed by #4769
Closed

Page asking for password of shared file contains "Request password" button #4523

mknet opened this issue Nov 3, 2020 · 6 comments · Fixed by #4769
Assignees
Labels
1. to develop bug feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents regression

Comments

@mknet
Copy link

mknet commented Nov 3, 2020

Steps to reproduce

  1. Create a password protected file share link
  2. Call the respective URL
  3. In addition to the form for entering the password for the sharing link, a button with the value "Restore password" is rendered.

Expected behaviour

I'd assume that this button shouldn't occur here. It's missleading since as I user I would press this button to send my entered password belonging to the share link

Actual behaviour

The button appears and IMHO misleads the user

Talk app

Talk app version: 10.0.1

If I deactivate the Talk app, the button is not rendered anymore.

@nickvergessen
Copy link
Member

The button does not display here. Can you post a screenshot and a list of installed apps?

@nickvergessen nickvergessen added feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents needs info and removed 0. Needs triage labels Nov 3, 2020
@mknet
Copy link
Author

mknet commented Nov 4, 2020

Thank you, @nickvergessen
Here is the particular markup which is rendered in the DOM

<div data-v-1ffb88f8=""><div data-v-1ffb88f8="" id="submit-wrapper" class="request-password-wrapper"><input data-v-1ffb88f8="" id="request-password-button" type="button" value="Passwort anfordern" class="primary"> <div data-v-1ffb88f8="" class="icon icon-confirm-white"></div></div> <!----></div>

and screenshots showing the button and the list of installed apps.

2020-11-04 14 24 51 a4532b700c27

2020-11-04 14 32 32  15c597700ec8

If it's an issue the screenshots are in German, drop me a line / comment.

Thanks

@nickvergessen nickvergessen changed the title Page asking for password of shared file contains "Restore password" button Page asking for password of shared file contains "Request password" button Nov 12, 2020
@nickvergessen nickvergessen added this to the 💚 Next Major (21) milestone Nov 12, 2020
@nickvergessen
Copy link
Member

@danxuliu with some recent changes the button seems to appear now all the time and not only when video verification is on.
Can you have a look?

@PVince81
Copy link
Member

confirmed. when clicking the button an error occurs.

I'll have a look.

@PVince81 PVince81 self-assigned this Dec 16, 2020
@PVince81
Copy link
Member

the button also appears in 10.0.3, so if it's a regression, likely happening even earlier

@PVince81
Copy link
Member

PR here: #4769

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop bug feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants