Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background image repeated on share link page #24200

Closed
mvvvmd opened this issue Nov 18, 2020 · 11 comments
Closed

Background image repeated on share link page #24200

mvvvmd opened this issue Nov 18, 2020 · 11 comments
Labels
1. to develop Accepted and waiting to be taken care of bug

Comments

@mvvvmd
Copy link

mvvvmd commented Nov 18, 2020

Steps to reproduce

  1. Create a share link for a file with password protection
  2. Open the link in a different browser or private window

Screenshot from 2020-11-18 09-32-22

Tested in several (clean) browsers on Ubuntu, Windows and Android with two Nextcloud instances.

Expected behaviour

The background image should display once.

Actual behaviour

The background image is repeated multiple times.

Server configuration

Operating system:

Ubuntu 18.04

Web server:

Apache 2.4

Database:

Mariadb 10.1

PHP version:
7.3

Nextcloud version: (see Nextcloud admin page)

20.0.1

Updated from an older Nextcloud/ownCloud or fresh install:

Both

Where did you install Nextcloud from:

nextcloud.com

@mvvvmd mvvvmd added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Nov 18, 2020
@kurn77
Copy link

kurn77 commented Nov 18, 2020

Hello, sorry > first I though I can reproduce but not : it was due to Custom CSS I was using.

Removing all in Custom CSS, I don't have a background image repeated multiple times.

@mvvvmd
Copy link
Author

mvvvmd commented Nov 18, 2020

I've tested on a third separately maintained NC instance (20.0.1) just now. Same issue there for me, no custom css in either instance. Note without a theme the issue does not appear, a custom background is required.

@jeremy13520
Copy link

Hello,
I have the same problem on the NC instance 20.0.1. I didn't customize the CSS, everything is by default on the CSS.

@kesselb
Copy link
Contributor

kesselb commented Nov 24, 2020

cc @juliushaertl @jancborchardt (as you were mentioned on the other issue I closed as duplicate).

@kesselb kesselb added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Nov 24, 2020
@juliusknorr
Copy link
Member

image

Sorry, cannot reproduce this here, maybe there is any other app that overwrites the styles? Could you check the body element for the styles that are applied?

image

@juliusknorr juliusknorr removed their assignment Dec 14, 2020
@mvvvmd
Copy link
Author

mvvvmd commented Dec 15, 2020

I've disabled all apps and the issue disappeared with only files and theming enabled. When I enable the Talk app the issue reappears, seems to be caused by this app.

@juliusknorr
Copy link
Member

@ma12-co or @danxuliu might know if something gets overwritten there.

@mvvvmd
Copy link
Author

mvvvmd commented Dec 15, 2020

Could be related to issue 24199, something with the video verification feature. That button also always shows up with the background multiplication.

@JSoko
Copy link
Member

JSoko commented Dec 16, 2020

I can confirm that the error goes away (on 20.0.4) when I turn off the Talk app.

But: this PR fixes it: nextcloud/spreed#4769

So if you don't wanna wait, just patch /var/www/nextcloud/apps/spreed/lib/PublicShareAuth/TemplateLoader.php on line 70
with

 	      // Check if "Video verification" option was set
		$share = $event->getShare();
		if (!$share->getSendPasswordByTalk()) {
			return;
		}

and anything is working fine again with talk activated...

@sergeng
Copy link

sergeng commented Aug 16, 2021

add
"background-repeat: no-repeat !important;"
"background-size: cover !important;"

in the following file
nano /netxcloud/apps/spreed/css/publicshareauth.scss

    #body-login {
            display: flex;
            justify-content: center;

            background-position: 50% 50%;
            background-repeat: repeat;
            background-repeat: no-repeat !important;
            background-size: 275px, contain;
            background-size: cover !important;
            background-attachment: fixed;

@ressit
Copy link

ressit commented Jun 24, 2022

With nc 22.2.9 the background image repetition is still observed in case video-ident is enabled for gaining permission.
Can be fixed by using the custom css app with entry

body.talk-sidebar-enabled #body-login {
    background-position: unset;
    background-repeat: no-repeat;
    background-size: cover;
    background-attachment: unset;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of bug
Projects
None yet
Development

No branches or pull requests

9 participants