Nextcloud 12 is not compatible with newer than php 7.1 #8216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MorrisJobke
reviewed
Feb 7, 2018
lib/versioncheck.php
Outdated
| } | ||
|
|
||
| // Show warning if > PHP 7.1 is used as Nextcloud 12 is not compatible with > PHP 7.1 | ||
| if (version_compare(PHP_VERSION, '7.2.0') !== -1) { |
There was a problem hiding this comment.
I guess you meant '7.1.0' here 😉
There was a problem hiding this comment.
So this will run with 7.2.0 just fine, but error out with 7.2.1+. 🤔
There was a problem hiding this comment.
No the version has to be lower than 7.2.0. So all 7.1.x are allowed.
There was a problem hiding this comment.
Just use , '<' instead of comparing !== -1
Codecov Report
@@ Coverage Diff @@
## stable12 #8216 +/- ##
==============================================
+ Coverage 53.84% 53.84% +<.01%
Complexity 22762 22762
==============================================
Files 1385 1386 +1
Lines 87152 87155 +3
Branches 1331 1331
==============================================
+ Hits 46926 46928 +2
- Misses 40226 40227 +1
|
rullzer
force-pushed
the
6830_12
branch
2 times, most recently
from
f3cb069
to
0d6c11a
Compare
Just to avoid users from trying this with a to new (untested) php version * Moved the check logic to 1 place * All directly callable scripts just require this on top * exit hard (-1) so we know scripts won't continue * Return status 500 so no sync clients will try fancy stuff Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
nickvergessen
approved these changes
Feb 7, 2018
MorrisJobke
approved these changes
Feb 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #6830
Fixes #7415
Just to avoid users from trying this with a to new (untested) php version
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl