Skip to content

Commit

Permalink
Nextcloud 12 is not compatible with newer than php 7.1
Browse files Browse the repository at this point in the history
Just to avoid users from trying this with a to new (untested) php version

* Moved the check logic to 1 place
* All directly callable scripts just require this on top
* exit hard (-1) so we know scripts won't continue
* Return status 500 so no sync clients will try fancy stuff

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
  • Loading branch information
rullzer committed Feb 7, 2018
1 parent 3df8021 commit f3cb069
Show file tree
Hide file tree
Showing 9 changed files with 31 additions and 29 deletions.
18 changes: 2 additions & 16 deletions console.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,28 +25,14 @@
*
*/

require_once __DIR__ . '/lib/versioncheck.php';

use OC\Console\Application;
use Symfony\Component\Console\Input\ArgvInput;
use Symfony\Component\Console\Output\ConsoleOutput;

define('OC_CONSOLE', 1);

// Show warning if a PHP version below 5.6.0 is used, this has to happen here
// because base.php will already use 5.6 syntax.
if (version_compare(PHP_VERSION, '5.6.0') === -1) {
echo 'This version of Nextcloud requires at least PHP 5.6.0'.PHP_EOL;
echo 'You are currently running ' . PHP_VERSION . '. Please update your PHP version.'.PHP_EOL;
return;
}

// Show warning if PHP 7.2 is used as Nextcloud is not compatible with PHP 7.2 for now
// @see https://github.com/nextcloud/server/pull/5791
if (version_compare(PHP_VERSION, '7.2.0') !== -1) {
echo 'This version of Nextcloud is not compatible with PHP 7.2.<br/>';
echo 'You are currently running ' . PHP_VERSION . '.';
return;
}

function exceptionHandler($exception) {
echo "An unhandled exception has been thrown:" . PHP_EOL;
echo $exception;
Expand Down
7 changes: 1 addition & 6 deletions cron.php
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,7 @@
*
*/

// Show warning if a PHP version below 5.6.0 is used
if (version_compare(PHP_VERSION, '5.6.0') === -1) {
echo 'This version of Nextcloud requires at least PHP 5.6.0<br/>';
echo 'You are currently running ' . PHP_VERSION . '. Please update your PHP version.';
return;
}
require_once __DIR__ . '/lib/versioncheck.php';

try {

Expand Down
8 changes: 1 addition & 7 deletions index.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,7 @@
*
*/

// Show warning if a PHP version below 5.6.0 is used, this has to happen here
// because base.php will already use 5.6 syntax.
if (version_compare(PHP_VERSION, '5.6.0') === -1) {
echo 'This version of Nextcloud requires at least PHP 5.6.0<br/>';
echo 'You are currently running ' . PHP_VERSION . '. Please update your PHP version.';
return;
}
require_once __DIR__ . '/lib/versioncheck.php';

// Show warning if PHP 7.2 is used as Nextcloud is not compatible with PHP 7.2 for now
// @see https://github.com/nextcloud/server/pull/5791
Expand Down
18 changes: 18 additions & 0 deletions lib/versioncheck.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
<?php

// Show warning if a PHP version below 5.6.0 is used, this has to happen here
// because base.php will already use 5.6 syntax.
if (version_compare(PHP_VERSION, '5.6.0') === -1) {
http_response_code(500);
echo 'This version of Nextcloud requires at least PHP 5.6.0<br/>';
echo 'You are currently running ' . PHP_VERSION . '. Please update your PHP version.';
exit(-1);
}

// Show warning if > PHP 7.1 is used as Nextcloud 12 is not compatible with > PHP 7.1
if (version_compare(PHP_VERSION, '7.2.0', '>=')) {
http_response_code(500);
echo 'This version of Nextcloud is not compatible with > PHP 7.2.<br/>';
echo 'You are currently running ' . PHP_VERSION . '.';
exit(-1);
}
1 change: 1 addition & 0 deletions ocs/providers.php
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
*
*/

require_once __DIR__ . '/../lib/versioncheck.php';
require_once __DIR__ . '/../lib/base.php';

header('Content-type: application/xml');
Expand Down
1 change: 1 addition & 0 deletions ocs/v1.php
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
*
*/

require_once __DIR__ . '/../lib/versioncheck.php';
require_once __DIR__ . '/../lib/base.php';

if (\OCP\Util::needUpgrade()
Expand Down
3 changes: 3 additions & 0 deletions public.php
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@
* along with this program. If not, see <http://www.gnu.org/licenses/>
*
*/

require_once __DIR__ . '/lib/versioncheck.php';

try {

require_once __DIR__ . '/lib/base.php';
Expand Down
2 changes: 2 additions & 0 deletions remote.php
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@
*
*/

require_once __DIR__ . '/lib/versioncheck.php';

use OCA\DAV\Connector\Sabre\ExceptionLoggerPlugin;
use Sabre\DAV\Exception\ServiceUnavailable;
use Sabre\DAV\Server;
Expand Down
2 changes: 2 additions & 0 deletions status.php
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@
*
*/

require_once __DIR__ . '/lib/versioncheck.php';

try {

require_once __DIR__ . '/lib/base.php';
Expand Down

0 comments on commit f3cb069

Please sign in to comment.