Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] Also make sure remote.php and public.php don't work on 7.2 #8209

Closed
wants to merge 1 commit into from

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Feb 6, 2018

Fixes #7415

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

Fixes #7415

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@codecov
Copy link

codecov bot commented Feb 6, 2018

Codecov Report

Merging #8209 into stable12 will decrease coverage by 0.01%.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             stable12    #8209      +/-   ##
==============================================
- Coverage       53.84%   53.82%   -0.02%     
  Complexity      22762    22762              
==============================================
  Files            1385     1385              
  Lines           87152    87168      +16     
  Branches         1331     1331              
==============================================
- Hits            46926    46922       -4     
- Misses          40226    40246      +20
Impacted Files Coverage Δ Complexity Δ
public.php 0% <0%> (ø) 0 <0> (ø) ⬇️
remote.php 0% <0%> (ø) 0 <0> (ø) ⬇️
core/js/js.js 61.27% <0%> (-0.56%) 0% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php 72.53% <0%> (+0.24%) 136% <0%> (ø) ⬇️

Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better to backport #6830 (as it covers too other files like cron.php or status.php)?

@rullzer
Copy link
Member Author

rullzer commented Feb 6, 2018

in theory I guess...

@MorrisJobke
Copy link
Member

Wouldn't it be better to backport #6830 (as it covers too other files like cron.php or status.php)?

Please do that.

@rullzer
Copy link
Member Author

rullzer commented Feb 7, 2018

see #8216

@rullzer rullzer closed this Feb 7, 2018
@rullzer rullzer deleted the fix_7415 branch February 7, 2018 09:49
@MorrisJobke MorrisJobke removed this from the Nextcloud 12.0.6 milestone Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants