fix: avoid douple expireDate parsing
#44838
Conversation
![github-advanced-security[bot]](https://github.com/avatars/in/57789?s=60&v=4){kind=small}
Fenn-CS
force-pushed
the
41229-expire-date-fed-share
branch
from
9241d0b
to
7c0832e
Compare
Fenn-CS
force-pushed
the
41229-expire-date-fed-share
branch
from
7c0832e
to
68753c9
Compare
Fenn-CS
added
3. to review
Fenn-CS
force-pushed
the
41229-expire-date-fed-share
branch
from
68753c9
to
63d5f75
Compare
Fenn-CS
changed the title
expireDate parsing
Fenn-CS
force-pushed
the
41229-expire-date-fed-share
branch
from
63d5f75
to
634df14
Compare
Fenn-CS
changed the title
expireDate parsingexpireDate parsing
Fenn-CS
force-pushed
the
41229-expire-date-fed-share
branch
3 times, most recently
from
b5b79cc
to
ff88095
Compare
|
Test failures related and looking. |
Fenn-CS
force-pushed
the
41229-expire-date-fed-share
branch
2 times, most recently
from
56e56d8
to
1c28f7a
Compare
… logger Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
`expireDate` can be set once and used anywhere needed, the current implementation, duplicates this behavior which leads to `parseDate` receiving an a date object it parsed and returend earlier in the createShare method. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Fenn-CS
force-pushed
the
41229-expire-date-fed-share
branch
from
1c28f7a
to
ec8a0a6
Compare
|
/backport to stable29 |
|
/backport to stable28 |
|
/backport to stable27 |
|
This actually breaks Talk attachment: |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Resolves : #41229