Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual/backport/44910/stable27 #45749

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Conversation

Fenn-CS
Copy link
Contributor

@Fenn-CS Fenn-CS commented Jun 10, 2024

Manual backport #44916 and #44838

@Fenn-CS Fenn-CS changed the title Manual/backport/4910/stable27 Manual/backport/44910/stable27 Jun 10, 2024
Fenn-CS and others added 3 commits June 11, 2024 14:17
… logger

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
`expireDate` can be set once and used anywhere needed, the current implementation,
duplicates this behavior which leads to `parseDate` receiving an a date object it
parsed and returend earlier in the createShare method.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
[EA] New value type (\DateTime) is not matching the resolved parameter type and might introduce types-related false-positives.

Signed-off-by: Joas Schilling <coding@schilljs.com>
@Fenn-CS Fenn-CS force-pushed the manual/backport/4910/stable27 branch from 85e55f7 to bacf8c6 Compare June 11, 2024 13:19
@Fenn-CS Fenn-CS enabled auto-merge June 11, 2024 13:44
@Fenn-CS Fenn-CS merged commit 9b39146 into stable27 Jun 11, 2024
38 checks passed
@Fenn-CS Fenn-CS deleted the manual/backport/4910/stable27 branch June 11, 2024 14:36
@blizzz blizzz mentioned this pull request Jun 11, 2024
1 task
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants