Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid douple expireDate parsing #44838

Merged
merged 2 commits into from
Apr 18, 2024
Merged

fix: avoid douple expireDate parsing #44838

merged 2 commits into from
Apr 18, 2024

Commits on Apr 18, 2024

  1. refactor(shareApiController): use contrusctor property promotion & DI… 

    … logger

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
    @Fenn-CS
    Fenn-CS committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    9a0913a View commit details
    Browse the repository at this point in the history

  2. fix(shareApiController): avoid duplicated expiryDate operations 

    `expireDate` can be set once and used anywhere needed, the current implementation,
duplicates this behavior which leads to `parseDate` receiving an a date object it
parsed and returend earlier in the createShare method.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
    @Fenn-CS
    Fenn-CS committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    ec8a0a6 View commit details
    Browse the repository at this point in the history