Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use deletion time instead of mtime in trashbin handling #42558

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

icewind1991
Copy link
Member

The mtime of the deleted file and the deletion time are the same with the standard trashbin backend, but this isn't necessarily the case for other backends.

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Jan 3, 2024
@icewind1991 icewind1991 requested review from Pytal, a team, ArtificialOwl, Altahrim and Fenn-CS and removed request for a team January 3, 2024 13:43
@icewind1991
Copy link
Member Author

nextcloud/groupfolders#2714 works around this for the groupfolder trash backend

@icewind1991 icewind1991 merged commit 62506a4 into master Jan 10, 2024
49 of 50 checks passed
@icewind1991 icewind1991 deleted the trash-mtime-deletion-time branch January 10, 2024 13:28
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants