Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix downloading trashbin items #2714

Merged
merged 1 commit into from
Jan 3, 2024
Merged

fix downloading trashbin items #2714

merged 1 commit into from
Jan 3, 2024

Conversation

icewind1991
Copy link
Member

The trashbin app makes some assumptions on how trash is stored in the backends to handle the download.

Signed-off-by: Robin Appelman <robin@icewind.nl>
@solracsf
Copy link
Member

solracsf commented Jan 3, 2024

Will this fix #2680 and/or #2657 ?

@Pytal Pytal assigned icewind1991 and unassigned Pytal Jan 3, 2024
@Pytal Pytal self-requested a review January 3, 2024 19:52
Copy link
Member

@Pytal Pytal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works! 💪

@Pytal Pytal added 4. to release Items that are ready for releasing and removed 3. to review Items that need to be reviewed labels Jan 3, 2024
@Pytal Pytal merged commit 1537598 into master Jan 3, 2024
37 checks passed
@Pytal Pytal deleted the trash-download branch January 3, 2024 19:53
@Pytal Pytal added the bug label Jan 3, 2024
@Pytal
Copy link
Member

Pytal commented Jan 3, 2024

/backport to stable28

@Pytal
Copy link
Member

Pytal commented Jan 3, 2024

/backport to stable27

@icewind1991
Copy link
Member Author

Will this fix #2680 and/or #2657 ?

I believe it fixes #2680, it works around #2657, but nextcloud/server#42558 is the proper fix for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Items that are ready for releasing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants