Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/webpack vendors bundles #30020

Merged
merged 28 commits into from
Jan 10, 2022
Merged

Feat/webpack vendors bundles #30020

merged 28 commits into from
Jan 10, 2022

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Dec 1, 2021

  • Reduce compile time by a power of 4
  • Move all bundles into /dist
  • Easier to cleanup
  • Easier to target old legacy js files
  • No more vue- or js/dist hacks
  • Bundle all shared modules into one big cached file

@artonge artonge force-pushed the feat/webpack-vendors-bundles branch from c4251a2 to e9039ed Compare December 1, 2021 21:34
@skjnldsv skjnldsv force-pushed the feat/webpack-vendors-bundles branch 2 times, most recently from 80c15ed to 5adab26 Compare December 2, 2021 18:14
@skjnldsv skjnldsv marked this pull request as ready for review December 2, 2021 18:14
@skjnldsv skjnldsv requested review from a team, PVince81, Pytal, szaimen, nickvergessen and artonge and removed request for a team December 2, 2021 18:15
@skjnldsv skjnldsv self-assigned this Dec 2, 2021
@skjnldsv skjnldsv added this to the Nextcloud 24 milestone Dec 2, 2021
core/src/OCP/collaboration.js Show resolved Hide resolved
lib/private/legacy/OC_Template.php Outdated Show resolved Hide resolved
webpack.common.js Outdated Show resolved Hide resolved
.eslintrc.js Show resolved Hide resolved
@skjnldsv skjnldsv force-pushed the feat/webpack-vendors-bundles branch 4 times, most recently from f5c36fe to 6eb2287 Compare December 2, 2021 21:41
@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Dec 3, 2021
@artonge artonge force-pushed the feat/webpack-vendors-bundles branch from 525c4ff to 60dc882 Compare December 3, 2021 13:04
@skjnldsv

This comment has been minimized.

Signed-off-by: Louis Chemineau <louis@chmn.me>
Reason: webpack/webpack#14628
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Reason: #27279
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 8, 2022

Rebased

@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 8, 2022

Scenario: delete a user                                                      # /drone/src/tests/acceptance/features/users.feature:25
130 | Given I act as Jane                                                        # ActorContext::iActAs()
131 | And I am logged in as the admin                                            # LoginPageContext::iAmLoggedInAsTheAdmin()
132 | And I open the User settings                                               # SettingsMenuContext::iOpenTheUserSettings()
133 | And I see that the list of users contains the user user0                   # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
134 | And I open the actions menu for the user user0                             # UsersSettingsContext::iOpenTheActionsMenuOf()
135 | And I see that the "Delete user" action in the user0 actions menu is shown # UsersSettingsContext::iSeeTheAction()
136 | Failed asserting that false is true.
137 | When I click the "Delete user" action in the user0 actions menu            # UsersSettingsContext::iClickTheAction()
138 | And I click the "Delete user0's account" button of the confirmation dialog # DialogContext::iClickTheDialogButton()
139 | Then I see that the list of users does not contains the user user0         # UsersSettingsContext::iSeeThatTheListOfUsersDoesNotContainsTheUser()
140

Is valid, the menu does not open anymore.

EDIT: fixed and pushed 🚀

@skjnldsv

This comment has been minimized.

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
* @param string $app the appname
* @param string|string[] $file the filename,
* if an array is given it will add all scripts
* @deprecated 23.1.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 23.1.0 ?
Should be 24 ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, my bad

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix on followup so we don't yet rebase this monstrous PR 🙈

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please add a pointer to its replacement.

lib/public/Util.php Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants