Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back missing personal Groupware settings bundle #31131

Closed
wants to merge 1 commit into from
Closed

Add back missing personal Groupware settings bundle #31131

wants to merge 1 commit into from

Conversation

ChristophWurst
Copy link
Member

Regression of #30020.

@ChristophWurst ChristophWurst added this to the Nextcloud 24 milestone Feb 11, 2022
@ChristophWurst ChristophWurst self-assigned this Feb 11, 2022
@ChristophWurst ChristophWurst force-pushed the fix/missing-groupware-personal-settings-bundle branch from 419e11d to 95ffce1 Compare February 11, 2022 12:47
@nextcloud-command nextcloud-command force-pushed the fix/missing-groupware-personal-settings-bundle branch from 95ffce1 to f0e85b4 Compare February 11, 2022 12:50
@ChristophWurst @nextcloud-command
Add back missing personal Groupware settings bundle
87d093b 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the fix/missing-groupware-personal-settings-bundle branch from f0e85b4 to 87d093b Compare February 11, 2022 12:52
@ChristophWurst ChristophWurst mentioned this pull request Feb 11, 2022
Merged
CarlSchwan
CarlSchwan approved these changes Feb 11, 2022
View reviewed changes
Copy link
Member

@CarlSchwan CarlSchwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the first regression due to this PR and probably not the last :(

@artonge
Copy link
Contributor

artonge commented Feb 11, 2022

This is not the first regression due to this PR and probably not the last :(

I guess every new bundle created between 01/12/2021 and 10/01/2022 are missing.

@ChristophWurst
Copy link
Member Author

Superseded by #31134

@ChristophWurst ChristophWurst deleted the fix/missing-groupware-personal-settings-bundle branch February 14, 2022 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@st3iny st3iny Awaiting requested review from st3iny

@GretaD GretaD Awaiting requested review from GretaD

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@ChristophWurst ChristophWurst

Labels
3. to review Waiting for reviews bug regression
Projects
None yet
Milestone
Nextcloud 24
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristophWurst @artonge @CarlSchwan