Eslint fix

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

.eslintrc.js

@@ -16,5 +16,9 @@ module.exports = {
 		// TODO: make sure we fix this as this is bad vue coding style.
 		// Use proper sync modifier
 		'vue/no-mutating-props': 'warn',
+		'vue/custom-event-name-casing': ['error', 'kebab-case', {
+			// allows custom xxxx:xxx events formats
+			ignores: ['/^[a-z]+(?:-[a-z]+)*:[a-z]+(?:-[a-z]+)*$/u'],
+		}],
 	},
 }

apps/comments/src/components/Comment.vue

@@ -166,15 +166,17 @@ export default {
 
 		/**
 		 * Is the current user the author of this comment
-		 * @returns {boolean}
+		 *
+		 * @return {boolean}
 		 */
 		isOwnComment() {
 			return getCurrentUser().uid === this.actorId
 		},
 
 		/**
 		 * Rendered content as html string
-		 * @returns {string}
+		 *
+		 * @return {string}
 		 */
 		renderedContent() {
 			if (this.isEmptyMessage) {
@@ -208,6 +210,7 @@ export default {
 	methods: {
 		/**
 		 * Update local Message on outer change
+		 *
 		 * @param {string} message the message to set
 		 */
 		updateLocalMessage(message) {

apps/comments/src/services/CommentsInstance.js

@@ -49,7 +49,7 @@ export default class CommentInstance {
 	 * Initialize a new Comments instance for the desired type
 	 *
 	 * @param {string} commentsType the comments endpoint type
-	 * @param  {Object} options the vue options (propsData, parent, el...)
+	 * @param  {object} options the vue options (propsData, parent, el...)
 	 */
 	constructor(commentsType = 'files', options) {
 		// Add comments type as a global mixin

apps/comments/src/services/GetComments.js

@@ -28,11 +28,11 @@ export const DEFAULT_LIMIT = 20
 /**
  * Retrieve the comments list
  *
- * @param {Object} data destructuring object
+ * @param {object} data destructuring object
  * @param {string} data.commentsType the ressource type
  * @param {number} data.ressourceId the ressource ID
- * @param {Object} [options] optional options for axios
- * @returns {Object[]} the comments list
+ * @param {object} [options] optional options for axios
+ * @return {object[]} the comments list
  */
 export default async function({ commentsType, ressourceId }, options = {}) {
 	let response = null
@@ -64,6 +64,10 @@ export default async function({ commentsType, ressourceId }, options = {}) {
 }
 
 // https://github.com/perry-mitchell/webdav-client/blob/9de2da4a2599e06bd86c2778145b7ade39fe0b3c/source/interface/directoryContents.js#L32
+/**
+ * @param result
+ * @param isDetailed
+ */
 function processMultistatus(result, isDetailed = false) {
 	// Extract the response items (directory contents)
 	const {
@@ -86,6 +90,10 @@ function processMultistatus(result, isDetailed = false) {
 	})
 }
 
+/**
+ * @param value
+ * @param passes
+ */
 function decodeHtmlEntities(value, passes = 1) {
 	const parser = new DOMParser()
 	let decoded = value

apps/comments/src/services/NewComment.js

@@ -31,7 +31,7 @@ import client from './DavClient'
  * @param {string} commentsType the ressource type
  * @param {number} ressourceId the ressource ID
  * @param {string} message the message
- * @returns {Object} the new comment
+ * @return {object} the new comment
  */
 export default async function(commentsType, ressourceId, message) {
 	const ressourcePath = ['', commentsType, ressourceId].join('/')

apps/comments/src/utils/cancelableRequest.js

@@ -24,15 +24,16 @@ import axios from '@nextcloud/axios'
 
 /**
  * Create a cancel token
- * @returns {CancelTokenSource}
+ *
+ * @return {CancelTokenSource}
  */
 const createCancelToken = () => axios.CancelToken.source()
 
 /**
  * Creates a cancelable axios 'request object'.
  *
- * @param {function} request the axios promise request
- * @returns {Object}
+ * @param {Function} request the axios promise request
+ * @return {object}
  */
 const cancelableRequest = function(request) {
 	/**
@@ -44,7 +45,7 @@ const cancelableRequest = function(request) {
 	 * Execute the request
 	 *
 	 * @param {string} url the url to send the request to
-	 * @param {Object} [options] optional config for the request
+	 * @param {object} [options] optional config for the request
 	 */
 	const fetch = async function(url, options) {
 		return request(

apps/comments/src/views/Comments.vue

@@ -126,7 +126,8 @@ export default {
 	methods: {
 		/**
 		 * Update current ressourceId and fetch new data
-		 * @param {Number} ressourceId the current ressourceId (fileId...)
+		 *
+		 * @param {number} ressourceId the current ressourceId (fileId...)
 		 */
 		async update(ressourceId) {
 			this.ressourceId = ressourceId
@@ -152,8 +153,9 @@ export default {
 
 		/**
 		 * Make sure we have all mentions as Array of objects
+		 *
 		 * @param {Array} mentions the mentions list
-		 * @returns {Object[]}
+		 * @return {object[]}
 		 */
 		genMentionsData(mentions) {
 			const list = Object.values(mentions).flat()
@@ -217,6 +219,7 @@ export default {
 
 		/**
 		 * Autocomplete @mentions
+		 *
 		 * @param {string} search the query
 		 * @param {Function} callback the callback to process the results with
 		 */
@@ -235,14 +238,16 @@ export default {
 
 		/**
 		 * Add newly created comment to the list
-		 * @param {Object} comment the new comment
+		 *
+		 * @param {object} comment the new comment
 		 */
 		onNewComment(comment) {
 			this.comments.unshift(comment)
 		},
 
 		/**
 		 * Remove deleted comment from the list
+		 *
 		 * @param {number} id the deleted comment
 		 */
 		onDelete(id) {

apps/dashboard/src/App.vue

@@ -266,7 +266,7 @@ export default {
 		 * Method to register panels that will be called by the integrating apps
 		 *
 		 * @param {string} app The unique app id for the widget
-		 * @param {function} callback The callback function to register a panel which gets the DOM element passed as parameter
+		 * @param {Function} callback The callback function to register a panel which gets the DOM element passed as parameter
 		 */
 		register(app, callback) {
 			Vue.set(this.callbacks, app, callback)

apps/dav/src/service/CalendarService.js

@@ -25,6 +25,9 @@ import { parseXML } from 'webdav/dist/node/tools/dav'
 import { getZoneString } from 'icalzone'
 import { v4 as uuidv4 } from 'uuid'
 
+/**
+ *
+ */
 export function getEmptySlots() {
 	return {
 		MO: [],
@@ -37,6 +40,9 @@ export function getEmptySlots() {
 	}
 }
 
+/**
+ *
+ */
 export async function findScheduleInboxAvailability() {
 	const client = getClient('calendars')
 
@@ -101,6 +107,10 @@ export async function findScheduleInboxAvailability() {
 	}
 }
 
+/**
+ * @param slots
+ * @param timezoneId
+ */
 export async function saveScheduleInboxAvailability(slots, timezoneId) {
 	const all = [...Object.keys(slots).flatMap(dayId => slots[dayId].map(slot => ({
 		...slot,

apps/dav/src/views/CalDavSettings.spec.js

@@ -31,7 +31,7 @@ describe('CalDavSettings', () => {
 		global.OCP = originalOCP
 	})
 
-	test('interactions', async() => {
+	test('interactions', async () => {
 		const TLUtils = render(
 			CalDavSettings,
 			{

apps/files/src/components/TemplatePreview.vue

@@ -102,7 +102,8 @@ export default {
 	computed: {
 		/**
 		 * Strip away extension from name
-		 * @returns {string}
+		 *
+		 * @return {string}
 		 */
 		nameWithoutExt() {
 			return this.basename.indexOf('.') > -1 ? this.basename.split('.').slice(0, -1).join('.') : this.basename

apps/files/src/models/Tab.js

@@ -34,7 +34,7 @@ export default class Tab {
 	/**
 	 * Create a new tab instance
 	 *
-	 * @param {Object} options destructuring object
+	 * @param {object} options destructuring object
 	 * @param {string} options.id the unique id of this tab
 	 * @param {string} options.name the translated tab name
 	 * @param {string} options.icon the vue component

apps/files/src/services/FileInfo.js

@@ -22,6 +22,9 @@
 
 import axios from '@nextcloud/axios'
 
+/**
+ * @param url
+ */
 export default async function(url) {
 	const response = await axios({
 		method: 'PROPFIND',

apps/files/src/services/Settings.js

@@ -34,7 +34,7 @@ export default class Settings {
 	 *
 	 * @since 19.0.0
 	 * @param {OCA.Files.Settings.Setting} view element to add to settings
-	 * @returns {boolean} whether registering was successful
+	 * @return {boolean} whether registering was successful
 	 */
 	register(view) {
 		if (this._settings.filter(e => e.name === view.name).length > 0) {
@@ -47,7 +47,8 @@ export default class Settings {
 
 	/**
 	 * All settings elements
-	 * @returns {OCA.Files.Settings.Setting[]} All currently registered settings
+	 *
+	 * @return {OCA.Files.Settings.Setting[]} All currently registered settings
 	 */
 	get settings() {
 		return this._settings

apps/files/src/services/Sidebar.js

@@ -41,7 +41,7 @@ export default class Sidebar {
 	 *
 	 * @readonly
 	 * @memberof Sidebar
-	 * @returns {Object} the data state
+	 * @return {object} the data state
 	 */
 	get state() {
 		return this._state
@@ -51,8 +51,8 @@ export default class Sidebar {
 	 * Register a new tab view
 	 *
 	 * @memberof Sidebar
-	 * @param {Object} tab a new unregistered tab
-	 * @returns {Boolean}
+	 * @param {object} tab a new unregistered tab
+	 * @return {boolean}
 	 */
 	registerTab(tab) {
 		const hasDuplicate = this._state.tabs.findIndex(check => check.id === tab.id) > -1
@@ -78,7 +78,7 @@ export default class Sidebar {
 	 * Return current opened file
 	 *
 	 * @memberof Sidebar
-	 * @returns {String} the current opened file
+	 * @return {string} the current opened file
 	 */
 	get file() {
 		return this._state.file

apps/files/src/utils/davUtils.js

@@ -41,7 +41,8 @@ export const getToken = function() {
 
 /**
  * Return the current directory, fallback to root
- * @returns {string}
+ *
+ * @return {string}
  */
 export const getCurrentDirectory = function() {
 	const currentDirInfo = OCA?.Files?.App?.currentFileList?.dirInfo

apps/files/src/utils/fileUtils.js

@@ -34,8 +34,8 @@ const encodeFilePath = function(path) {
 /**
  * Extract dir and name from file path
  *
- * @param {String} path the full path
- * @returns {String[]} [dirPath, fileName]
+ * @param {string} path the full path
+ * @return {string[]} [dirPath, fileName]
  */
 const extractFilePaths = function(path) {
 	const pathSections = path.split('/')