Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Side menu is almost unusable on small resolution #34777

Closed
7 of 9 tasks
Tracked by #1280
Mer0me opened this issue Oct 24, 2022 · 20 comments · Fixed by nextcloud-libraries/nextcloud-vue#3444, #35179 or #35972
Closed
7 of 9 tasks
Tracked by #1280

Comments

@Mer0me
Copy link

Mer0me commented Oct 24, 2022

⚠️ This issue respects the following points: ⚠️

  • This is a bug, not a question or a configuration/webserver/proxy issue.
  • This issue is not already reported on Github (I've searched it).
  • Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
  • Nextcloud Server is running on 64bit capable CPU, PHP and OS.
  • I agree to follow Nextcloud's Code of Conduct.

Bug description

My laptop screen has this screen resolution : 1366x768px

Displaying the side menu of a file with a preview on firefox maximized (but not full screen) :

image

It's very difficult to use the share drop-down list and to access internal link and other informations in side menu in these conditions.

Steps to reproduce

  1. Reduce the height of the browser window or use an old screen
  2. Display the side menu of a file with a preview thumbnail
  3. Try to share it or to get the internal link

Expected behavior

UI should be responsive and should propose to minimize/toggle the thumbnail preview or detecting the height of the div, toggle it itself.

Installation method

Community Web installer on a VPS or web space

Operating system

Debian/Ubuntu

PHP engine version

PHP 7.4

Web server

Apache (supported)

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

No response

Are you using the Nextcloud Server Encryption module?

No response

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

{
    "system": {
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "merome.net",
            "cloud.merome.net",
            "192.168.1.100"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "overwrite.cli.url": "https:\/\/merome.net\/owncloud",
        "dbtype": "mysql",
        "version": "25.0.0.18",
        "logtimezone": "UTC",
        "installed": true,
        "theme": "",
        "loglevel": 0,
        "maintenance": false,
        "trashbin_retention_obligation": "auto",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpmode": "sendmail",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "updater.release.channel": "stable",
        "mail_sendmailmode": "smtp",
        "app_install_overwrite": [
            "calendar",
            "onlyoffice",
            "spreed",
            "files_mindmap",
            "files_texteditor",
            "external",
            "deck"
        ],
        "mysql.utf8mb4": true,
        "memcache.local": "\\OC\\Memcache\\Redis",
        "has_rebuilt_cache": true,
        "app.mail.verify-tls-peer": false,
        "default_phone_region": "FR",
        "debut": true,
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "filelocking.enabled": "true",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": 0,
            "timeout": 0
        },
        "trusted_proxies": "***REMOVED SENSITIVE VALUE***"
    }
}

List of activated Apps

Enabled:
  - activity: 2.17.0
  - admin_audit: 1.15.0
  - calendar: 4.0.1
  - circles: 25.0.0
  - cloud_federation_api: 1.8.0
  - comments: 1.15.0
  - contacts: 5.0.1
  - contactsinteraction: 1.6.0
  - dashboard: 7.5.0
  - dav: 1.24.0
  - external: 5.0.0
  - federatedfilesharing: 1.15.0
  - federation: 1.15.0
  - files: 1.20.1
  - files_external: 1.17.0
  - files_mindmap: 0.0.26
  - files_pdfviewer: 2.6.0
  - files_rightclick: 1.4.0
  - files_sharing: 1.17.0
  - files_texteditor: 2.14.0
  - files_trashbin: 1.15.0
  - files_versions: 1.18.0
  - files_zip: 1.1.2
  - firstrunwizard: 2.14.0
  - forms: 3.0.0
  - integration_mastodon: 1.0.3
  - integration_twitter: 1.0.3
  - logreader: 2.10.0
  - lookup_server_connector: 1.13.0
  - mail: 2.0.3
  - maps: 0.2.1
  - nextcloud_announcements: 1.14.0
  - notifications: 2.13.1
  - notify_push: 0.5.0
  - oauth2: 1.13.0
  - onlyoffice: 7.6.6
  - password_policy: 1.15.0
  - photos: 2.0.0
  - polls: 4.0.0
  - privacy: 1.9.0
  - provisioning_api: 1.15.0
  - recommendations: 1.4.0
  - related_resources: 1.0.1
  - serverinfo: 1.15.0
  - settings: 1.7.0
  - sharebymail: 1.15.0
  - snappymail: 2.19.2
  - spreed: 15.0.0
  - support: 1.8.0
  - survey_client: 1.13.0
  - suspicious_login: 4.3.0
  - systemtags: 1.15.0
  - text: 3.6.0
  - theming: 2.0.0
  - twofactor_backupcodes: 1.14.0
  - updatenotification: 1.15.0
  - user_status: 1.5.0
  - viewer: 1.9.0
  - weather_status: 1.5.0
  - workflowengine: 2.7.0
Disabled:
  - bruteforcesettings: 2.2.0
  - deck: 1.7.1
  - duplicatefinder: 0.0.15
  - emlviewer: 1.0.2
  - encryption
  - extract: 1.3.2
  - files_markdown: 2.3.6
  - passwords: 2022.10.10
  - tables: 0.2.0
  - twofactor_totp
  - user_ldap
  - workspace

Nextcloud Signing status

No errors have been found.

Nextcloud Logs

Not relevant

Additional info

No response

@Mer0me Mer0me added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Oct 24, 2022
@tmllull
Copy link

tmllull commented Oct 26, 2022

Same with other sections:

Calendar: the input text for the name is "overflow" behind the limits of the calendar.
imagen

Contacts: the limit space list is "overflow" behind the settings button.
imagen

This is very frustrating...

@PVince81
Copy link
Member

it was already difficult before, now with the extra pixels from the border it got worse.

for the files sidebar the issue is mostly when there's a thumbnail, maybe that one should reduce itself further ?

@jancborchardt

@szaimen szaimen added 2. developing Work in progress and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Nov 8, 2022
@szaimen
Copy link
Contributor

szaimen commented Nov 8, 2022

Keeping it open to keep track of it

@szaimen szaimen reopened this Nov 8, 2022
@szaimen
Copy link
Contributor

szaimen commented Nov 8, 2022

Needs:

  • backport to vue 7
  • new release of vue 7
  • merge of new vue 7 in master
  • backport of new vue 7 to stable25

@jancborchardt
Copy link
Member

Just to be clear @szaimen, the fix is to make the whole height of the sidebar scrollable right? I think that’s good :)

@szaimen
Copy link
Contributor

szaimen commented Nov 15, 2022

Just to be clear @szaimen, the fix is to make the whole height of the sidebar scrollable right? I think that’s good :)

Yep and thanks :)

@szaimen
Copy link
Contributor

szaimen commented Nov 15, 2022

Reopening for the last missing step

@skjnldsv
Copy link
Member

skjnldsv commented Dec 9, 2022

Better fix proposal, use compact mode on low-height screen resolutions.

Before After
2022-12-09_08-22 2022-12-09_08-23

@szaimen szaimen reopened this Dec 9, 2022
@szaimen szaimen added 1. to develop Accepted and waiting to be taken care of and removed 2. developing Work in progress labels Dec 9, 2022
@szaimen szaimen added this to the Nextcloud 25.0.3 milestone Dec 9, 2022
@PVince81
Copy link
Member

@skjnldsv can you help here ?

@skjnldsv
Copy link
Member

Yep

@szaimen
Copy link
Contributor

szaimen commented Dec 20, 2022

Ping @skjnldsv ? :)

@szaimen
Copy link
Contributor

szaimen commented Dec 20, 2022

This has become more urgent now that vue 7.2.0 was merged into stable25. Otherwise we would need to revert vue 7.2.0 again to not risk re-introducing this regression in 25.0.3

@PVince81
Copy link
Member

PVince81 commented Jan 3, 2023

@Pytal please have a look, this is also an accessibility topic and is blocking further accessibility improvements in nextcloud-vue as we can't update the library further (see #35877)

fyi @AndyScherzinger

@skjnldsv
Copy link
Member

skjnldsv commented Jan 3, 2023

I don't remember what the issue was, but with my comment above

Better fix proposal, use compact mode on low-height screen resolutions.

There is no need for any vue update.
The only fix necessary is on server:

compact: !this.fileInfo.hasPreview || this.isFullScreen,

Just add one screen height check here (with an onresize watcher to update accordingly)

@Cwpute

This comment was marked as off-topic.

@szaimen

This comment was marked as resolved.

@Cwpute

This comment was marked as off-topic.

@szaimen
Copy link
Contributor

szaimen commented Jan 3, 2023

WIP here: #35972. @skjnldsv please have a look!

@szaimen szaimen added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Jan 3, 2023
@szaimen
Copy link
Contributor

szaimen commented Jan 4, 2023

Reopening to keep track of the backport

@szaimen
Copy link
Contributor

szaimen commented Jan 4, 2023

@szaimen szaimen closed this as completed Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment