Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

appsidebar should be compact when opened on small heights #35972

Merged
merged 1 commit into from
Jan 4, 2023
Merged

appsidebar should be compact when opened on small heights #35972

merged 1 commit into from
Jan 4, 2023

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Jan 3, 2023 •
edited
Loading

Fix #34777

Before After
image image
For my own testing 
docker run -it \
--name nextcloud-easy-test \
-p 8443:443 \
-e TRUSTED_DOMAIN=192.168.24.128 \
--volume="nextcloud_easy_test_npm_cache_volume:/var/www/.npm" \
-e SERVER_BRANCH=fix/34777/improve-app-sidebar \
-e COMPILE_SERVER=1 \
ghcr.io/szaimen/nextcloud-easy-test:latest

@szaimen szaimen added this to the Nextcloud 26 milestone Jan 3, 2023
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 3, 2023
@szaimen szaimen requested review from juliusknorr, artonge, skjnldsv, a team and Pytal and removed request for a team January 3, 2023 23:17
@szaimen szaimen marked this pull request as ready for review January 3, 2023 23:17
@szaimen szaimen mentioned this pull request Jan 3, 2023
Closed
9 tasks
@szaimen
Copy link
Contributor Author

szaimen commented Jan 3, 2023

/compile amend /

Pytal
Pytal approved these changes Jan 4, 2023
View reviewed changes
apps/files/src/views/Sidebar.vue Outdated Show resolved Hide resolved
skjnldsv
skjnldsv requested changes Jan 4, 2023
View reviewed changes
apps/files/src/views/Sidebar.vue Outdated Show resolved Hide resolved
@szaimen szaimen force-pushed the fix/34777/improve-app-sidebar branch from a853216 to bc30087 Compare January 4, 2023 09:08
@szaimen
Copy link
Contributor Author

szaimen commented Jan 4, 2023

/compile amend /

@szaimen szaimen requested a review from skjnldsv January 4, 2023 09:09
@szaimen @nextcloud-command
appsidebar should be compact when opened on small heights
088e9b0 
Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
PVince81
PVince81 approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 7e58906 into master Jan 4, 2023
@PVince81 PVince81 deleted the fix/34777/improve-app-sidebar branch January 4, 2023 11:46
@PVince81
Copy link
Member

PVince81 commented Jan 4, 2023

/backport to stable25

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 4, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@Pytal Pytal Pytal approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@artonge artonge Awaiting requested review from artonge

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug regression
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.

[Bug]: Side menu is almost unusable on small resolution
4 participants
@szaimen @PVince81 @skjnldsv @Pytal