fix sidebar scrolling for small displays

[szaimen]

Fix nextcloud/server#34777

Before	After

Signed-off-by: Simon L szaimen@e.mail.de

[szaimen]

/backport to stable7

[raimund-schluessler]

I think this is there intentionally, to keep the header visible at all times. If apps don't work well with it, it can be overwritten by the app itself.

[szaimen]

I think this is there intentionally, to keep the header visible at all times. If apps don't work well with it, it can be overwritten by the app itself.

I have not yet found one app that really works well with this. So I'd rather fix this in general.

But would be fine for me ot overwrite this in server. WDYT @nextcloud/server ?

[szaimen]

/backport to stable7

[danxuliu]

Making the whole sidebar scrollable is problematic when the sidebar is very tall. For example, in the Comments section of Files if there are a lot of comments, or in Talk during calls, when the chat is shown in the sidebar; in the case of Talk it is specially bad, as the newest messages are at the bottom. Due to this you need to scroll all the way down to see the messages, and you need to scroll all the way up to change to another tab (and besides being uncomfortable to use it also breaks scrolling because the older messages are loaded when you scroll to the top).

But even ignoring Talk the (in my opinion) usability concerns regarding excesive scrolling apply too to Files, for example.

Therefore I would suggest a different fix. Instead of removing min-height: 0 it could be replaced by height: 100%. This way the tabs would get the height of the sidebar, so it would be scrollable if the header and the tab do not fit in the screen, but the general scrolling would end when the tab headers are at the top, at which point the internal scrolling of the tab contents would start. With this you will always be able to switch between tabs, and if you need to show the sidebar header again it would be just scrolling its own height rather than the full sidebar height.

With that fix Talk would still need some further work, because the "New message" area would be hidden and the user would need to scroll down until the tab is fully shown to see it. But even if we just end setting min-height: 0 for Talk for the time being at least it should fix the issues in Files (I have not checked other apps, though).

However... please take all that with a pinch of salt, because my CSS is quite rusty and maybe that introduces more issues than it fixes ;-)

[nickvergessen]

As per above this is a breaking change?
So need to bump the major version?
Or can we somehow limit this or make it optional so it does not change the scrolling behaviour completely?!