Revert @nextcloud/vue changes to sidebar scrolling #8418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since @nextcloud/vue 7.1.0-beta.0 the tabs in the right sidebar expand to the full height of its contents, which causes the sidebar to be fully scrollable, rather than scrollable only in the tab contents, which breaks the chat when shown in the sidebar. Until a better fix is found for now the changes in the sidebar CSS from @nextcloud/vue that causes that are reverted specifically for Talk. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
added
3. to review
bug
regression
feature: chat 💬
|
Let's only revert in stable25 |
|
Also seeing the PR a |
nickvergessen
approved these changes
Dec 1, 2022
nickvergessen
deleted the
revert-nextcloud-vue-changes-to-sidebar-scrolling
branch
|
/backport to stable25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since @nextcloud/vue 7.1.0-beta.0 the tabs in the right sidebar expand to the full height of its contents, which causes the sidebar to be fully scrollable, rather than scrollable only in the tab contents, which breaks the chat when shown in the sidebar.
Until a better fix is found for now the changes in the sidebar CSS from @nextcloud/vue that causes that are reverted specifically for Talk.