Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove UTF-8 charset warning from news #496

Closed
1 task done
danopz opened this issue Apr 15, 2019 · 2 comments
Closed
1 task done

Remove UTF-8 charset warning from news #496

danopz opened this issue Apr 15, 2019 · 2 comments

Comments

@danopz
Copy link
Contributor

danopz commented Apr 15, 2019 •
edited by jospoortvliet
Loading

Explain the Problem

Currently when we are running Nextcloud with MySQL without utf8mb4 enabled we are showing a notice in the notifications for this: Non UTF-8 charset for MySQL/MariaDB database detected!.
Now that this warning is added to the server (nextcloud/server#14398, nextcloud/server#14857) setup check directly we could probably remove it from the news app - we shouldn't duplicate warnings here.

I would just like to know what you think. If decided I will create a pull request for that.
@SMillerDev
Copy link
Contributor

Nice find, I'd be happy to get rid of this. Please look at documentation too when you remove it 👍

danopz added a commit to danopz/news that referenced this issue Apr 16, 2019
@danopz
removed warning about non utf8mb4 charset for mysql/mariadb - nextclo…
909d91d 
…ud#496
@danopz danopz mentioned this issue Apr 16, 2019
Merged
danopz added a commit to danopz/news that referenced this issue Apr 17, 2019
@danopz
removed warning about non utf8mb4 charset for mysql/mariadb - nextclo…
c24cc00 
…ud#496

Signed-off-by: Daniel Opitz <git@copynpaste.de>
Grotax pushed a commit that referenced this issue Apr 25, 2019
@danopz @Grotax
removed warning about non utf8mb4 charset for mysql/mariadb - #496 (#497
10c0b1f 
)

Signed-off-by: Daniel Opitz <git@copynpaste.de>
@Grotax
Copy link
Member

Grotax commented Apr 25, 2019

Thanks

@Grotax Grotax closed this as completed Apr 25, 2019
nachoparker added a commit to nachoparker/news that referenced this issue May 11, 2019
@nachoparker
Merge remote-tracking branch 'origin/master' into css-tweak-tablet-sc…
e2bda14 
…reen

* origin/master: (32 commits)
  prevent menu actions from collapsing sidebar (nextcloud#504)
  add "mark read" floating button mobile. Fixes nextcloud#469 (nextcloud#505)
  [tx-robot] updated from transifex
  [tx-robot] updated from transifex
  update js dependencies (nextcloud#500)
  [tx-robot] updated from transifex
  removed warning about non utf8mb4 charset for mysql/mariadb - nextcloud#496 (nextcloud#497)
  [tx-robot] updated from transifex
  [tx-robot] updated from transifex
  Update feed-io: adds UT timezone (nextcloud#495)
  [tx-robot] updated from transifex
  [tx-robot] updated from transifex
  Release 13.1.6 (nextcloud#490)
  Use nextclouds temp dir (nextcloud#493)
  [tx-robot] updated from transifex
  [tx-robot] updated from transifex
  UI: Make BasicAuth Credentials less important in subscribtion form
  Set tmp dir as cache for favicon
  embed codecov status
  remove coverage from integration run, upload to codecov
  ...

Signed-off-by: nachoparker <nacho@ownyourbits.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@SMillerDev @danopz @Grotax