Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent menu actions from collapsing sidebar #504

Merged

Conversation

nachoparker
Copy link
Member

@nachoparker nachoparker commented May 7, 2019

It makes the menu hard to use to unusable on mobile / tablet

Before

news-collapse-before-fix

After

news-collapse-after-fix

Signed-off-by: nachoparker <nacho@ownyourbits.com>
@nachoparker nachoparker force-pushed the prevent-menu-actions-collapse-sidebar branch from f11e3ff to ac543af Compare May 7, 2019 01:11
@SMillerDev SMillerDev requested a review from Grotax May 7, 2019 11:33
Copy link
Member

@Grotax Grotax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks 👍

@Grotax Grotax merged commit a363aab into nextcloud:master May 11, 2019
nachoparker added a commit to nachoparker/news that referenced this pull request May 11, 2019
…reen

* origin/master: (32 commits)
  prevent menu actions from collapsing sidebar (nextcloud#504)
  add "mark read" floating button mobile. Fixes nextcloud#469 (nextcloud#505)
  [tx-robot] updated from transifex
  [tx-robot] updated from transifex
  update js dependencies (nextcloud#500)
  [tx-robot] updated from transifex
  removed warning about non utf8mb4 charset for mysql/mariadb - nextcloud#496 (nextcloud#497)
  [tx-robot] updated from transifex
  [tx-robot] updated from transifex
  Update feed-io: adds UT timezone (nextcloud#495)
  [tx-robot] updated from transifex
  [tx-robot] updated from transifex
  Release 13.1.6 (nextcloud#490)
  Use nextclouds temp dir (nextcloud#493)
  [tx-robot] updated from transifex
  [tx-robot] updated from transifex
  UI: Make BasicAuth Credentials less important in subscribtion form
  Set tmp dir as cache for favicon
  embed codecov status
  remove coverage from integration run, upload to codecov
  ...

Signed-off-by: nachoparker <nacho@ownyourbits.com>
@nachoparker nachoparker deleted the prevent-menu-actions-collapse-sidebar branch May 11, 2019 15:03
Grotax added a commit that referenced this pull request Aug 16, 2019
- Dropped support for Nextcloud 14 & 15 #494
- Switched to feedio 4.3 #494
- News now requires PHP 7.1 #494
- Removed UTF-8 warning (now included in server) #497
- UI imporvements #505 #504 #467

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Grotax added a commit that referenced this pull request Sep 19, 2019
- Dropped support for Nextcloud 14 & 15 #494
- Switched to feedio 4.3 #494
- News now requires PHP 7.1 #494
- Removed UTF-8 warning (now included in server) #497
- UI improvements #505 #504 #467
- Add the 'Accept' header to requests #525

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants