-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setup check for missing UTF8MB4 on mysql #14398
Merged
MorrisJobke
merged 1 commit into
master
from
feature/14394/add-setup-check-for-mysql-utf8mb4
Feb 28, 2019
Merged
Add setup check for missing UTF8MB4 on mysql #14398
MorrisJobke
merged 1 commit into
master
from
feature/14394/add-setup-check-for-mysql-utf8mb4
Feb 28, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MorrisJobke
requested review from
rullzer,
nickvergessen,
blizzz,
weeman1337 and
skjnldsv
February 27, 2019 09:48
skjnldsv
approved these changes
Feb 27, 2019
nickvergessen
approved these changes
Feb 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didnt test, but looks good
MorrisJobke
force-pushed
the
feature/14394/add-setup-check-for-mysql-utf8mb4
branch
from
February 27, 2019 10:53
e0c9690
to
3a6d3b8
Compare
MorrisJobke
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
3. to review
Waiting for reviews
labels
Feb 27, 2019
CI not happy |
I know, but I have no idea why - it works locally just fine :/ |
Unrelated failures - let me squash this then: Status of 16578: failure
Show full log
Show full log
|
MorrisJobke
force-pushed
the
feature/14394/add-setup-check-for-mysql-utf8mb4
branch
from
February 28, 2019 15:45
113527b
to
6c7ccbe
Compare
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
🎉 |
Failures are unrelated. |
MorrisJobke
deleted the
feature/14394/add-setup-check-for-mysql-utf8mb4
branch
February 28, 2019 21:39
/backport to stable15 |
backport to stable15 in #14857 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #14394 (comment)
Looks then like this: