-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add outbox backend implementation #6031
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
33fe493
to
7f89fc9
Compare
1120eeb
to
4606428
Compare
CI should run but doesn't. I hope this is just a Github hiccup. This PR doesn't even change/touch the workflow files. |
StatAna isn't liking the event dispatcher, otherwise it looks ok |
Use the interface instead of the implementation |
a254f62
to
d87425d
Compare
The first argument should be a path to your file, not the contents as string |
I did try this for sure, I'm not Jared who's 19 and can't read ;) But it doesn't matter anyway: public function getRaw($stream = true)
{
if ($stream) {
$hdr = new Horde_Stream();
$hdr->add($this->_headers->toString(), true);
return Horde_Stream_Wrapper_Combine::getStream(
array($hdr->stream,
$this->getBasePart()->toString(
array('stream' => true, 'encode' => Horde_Mime_Part::ENCODE_7BIT | Horde_Mime_Part::ENCODE_8BIT | Horde_Mime_Part::ENCODE_BINARY))
)
);
}
return $this->_headers->toString() . $this->getBasePart()->toString();
} There is no way to get the additional body parts from a raw message. |
50d4d4e
to
d19d3d3
Compare
bede574
to
c712280
Compare
} catch (ClientException $e) { | ||
$this->logger->info("Message in reply " . $messageId . " could not be loaded: " . $e->getMessage()); | ||
} | ||
$repliedMessageData = new RepliedMessageData($account, $repliedMessage); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what the old data structure and identification allowed was to receive a message with account A, reply with account B and still get the flag updates on account A. This will break now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Raised as #6189
c712280
to
a2ca2f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works
Code looks good but couldn't grasp all the changes due to the size of the patch
Co-Authored-By: Christoph Wurst <christoph@winzerhof-wurst.at> Signed-off-by: Anna Larch <anna@nextcloud.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
a2ca2f2
to
c90c788
Compare
Closes #6139
fwrite
error